Skip to content

Slider: side labels #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mischnic opened this issue Sep 23, 2020 · 1 comment
Closed

Slider: side labels #970

mischnic opened this issue Sep 23, 2020 · 1 comment
Labels
bug Results from a bug in the CSS implementation sync to jira These will be pushed into adobe internal jira

Comments

@mischnic
Copy link
Contributor

mischnic commented Sep 23, 2020

Description

There should be a class for putting the label on the side of the slider: https://spectrum.adobe.com/page/slider/#Label-position

Screenshots

This should be possible:

Bildschirmfoto 2020-09-23 um 19 13 25

Environment

Additional context

Trying to upstream this to minimize changes in the CSS "fork" in the React Spectrum repo: adobe/react-spectrum#1083

I've tried to implement this, though it's not perfect: https://reactspectrum.blob.core.windows.net/reactspectrum/797685ea11c15e51df80889902724c7a0073d78d/storybook/index.html?path=/story/slider--labelposition-side

CSS:

https://github.com/adobe/react-spectrum/blob/797685ea11c15e51df80889902724c7a0073d78d/packages/%40adobe/spectrum-css-temp/components/slider/skin.css#L308-L325

@mischnic mischnic added the bug Results from a bug in the CSS implementation label Sep 23, 2020
@pfulton pfulton added the sync to jira These will be pushed into adobe internal jira label Jul 18, 2022
@pfulton
Copy link
Collaborator

pfulton commented Jul 18, 2022

@Deanna-w1 let's look at this one when we migrate and work on Slider.

@pfulton pfulton closed this as completed Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Results from a bug in the CSS implementation sync to jira These will be pushed into adobe internal jira
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants