Skip to content

[ENH] Ensure that predict and predict_proba produce comparable output #2802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MatthewMiddlehurst opened this issue May 14, 2025 · 0 comments · May be fixed by #2824
Open

[ENH] Ensure that predict and predict_proba produce comparable output #2802

MatthewMiddlehurst opened this issue May 14, 2025 · 0 comments · May be fixed by #2824
Labels
classification Classification package clustering Clustering package enhancement New feature, improvement request or other non-bug code enhancement testing Testing related issue or pull request

Comments

@MatthewMiddlehurst
Copy link
Member

Describe the feature or idea you want to propose

I'm not sure that we actually test that the max value in predict_proba matches the prediction in predict. We should do IMO. This can be added to the already present "output" tests in the general testing. I think this would only be relevant for classification and clustering.

Describe your proposed solution

Add a test that compares predict and predict_proba output in the testing module checks.

Describe alternatives you've considered, if relevant

No response

Additional context

No response
@MatthewMiddlehurst MatthewMiddlehurst added enhancement New feature, improvement request or other non-bug code enhancement classification Classification package clustering Clustering package testing Testing related issue or pull request labels May 14, 2025
@notaryanramani notaryanramani linked a pull request May 19, 2025 that will close this issue
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
classification Classification package clustering Clustering package enhancement New feature, improvement request or other non-bug code enhancement testing Testing related issue or pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ENH] Adds a check for consistent output for predict and predict_proba notaryanramani/aeon
1 participant
@MatthewMiddlehurst