Skip to content

Split Relation.Binary.Lattice out into standard hierarchy #1469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MatthewDaggitt opened this issue Apr 12, 2021 · 2 comments · Fixed by #1571
Closed

Split Relation.Binary.Lattice out into standard hierarchy #1469

MatthewDaggitt opened this issue Apr 12, 2021 · 2 comments · Fixed by #1571
Labels
library-design low-hanging-fruit refactoring
Milestone
v2.0

Comments

@MatthewDaggitt
Copy link
Contributor

MatthewDaggitt commented Apr 12, 2021 •
edited
Loading

In the same way that Relation.Binary is split into Definitions/Structures/Bundles so should Relation.Binary.Lattice be split into Lattice.(Definitions/Structures/Bundles). This would allow some simplification by having the equality and order relations as module parameters to Lattice.Definitions and Lattice.Structures.

See also #1108 which attempts to do the same thing for algebraic latttices
@MatthewDaggitt MatthewDaggitt added this to the v2.0 milestone Apr 12, 2021
@Akshobhya1234
Copy link
Contributor

Akshobhya1234 commented Aug 2, 2021 •
edited
Loading

@MatthewDaggitt This means we need to pull from current Relation.Binary.Lattice.agda and create Lattice.(Definitions/Structures/Bundles) accordingly right? Should it be Relation.Lattice.(Definitions/Structures/Bundles) or Relation.Binary.Lattice.(Definitions/Structures/Bundles)?

@MatthewDaggitt
Copy link
Contributor Author

Yes, Relation.Binary.Lattice.(Definitions/Structures/Bundles). A PR would be most welcome 😄

@Akshobhya1234 Akshobhya1234 mentioned this issue Aug 3, 2021
Merged
@MatthewDaggitt MatthewDaggitt linked a pull request Aug 9, 2021 that will close this issue
Split Relation.Binary.Lattice out into standard hierarchy #1571
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
library-design low-hanging-fruit refactoring
Projects
None yet
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

Split Relation.Binary.Lattice out into standard hierarchy
2 participants
@MatthewDaggitt @Akshobhya1234