Skip to content

Algebra.Morphism.Structures: redundant fields in ring-like morphisms #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Taneb opened this issue Jul 6, 2021 · 1 comment · Fixed by #1540
Closed

Algebra.Morphism.Structures: redundant fields in ring-like morphisms #1539

Taneb opened this issue Jul 6, 2021 · 1 comment · Fixed by #1540
Milestone

Comments

@Taneb
Copy link
Member

Taneb commented Jul 6, 2021

Consider the IsRingHomomorphism structure. It winds up having two different, not-necessarily-equal definitions of IsRelHomomorphism _≈₁_ _≈₂_ ⟦_⟧, one via the proof that addition is a group homomorphism and one via the proof that multiplication is a monoid homomorphism.

I'm working on a fix for this that defines, for example, a ring homomorphism as a semiring homomorphism plus a proof that negation is homomorphic.

@MatthewDaggitt
Copy link
Contributor

Thanks, sounds like a good idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants