Skip to content

Add IsRingWithoutOne and RingWithoutOne #1687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Taneb opened this issue Jan 13, 2022 · 4 comments · Fixed by #1690
Closed

Add IsRingWithoutOne and RingWithoutOne #1687

Taneb opened this issue Jan 13, 2022 · 4 comments · Fixed by #1690
Labels
Milestone

Comments

@Taneb
Copy link
Member

Taneb commented Jan 13, 2022

These are useful for talking about ideals of rings, which in general have this form.

@Akshobhya1234
Copy link
Contributor

@Taneb Is it Rng as defined here? If required I can migrate it to stdlib

record IsRng (+ * : Op₂ A) (-_ : Op₁ A) (0# : A) : Set (a ⊔ ℓ) where
field
+-isAbelianGroup : IsAbelianGroup + 0# -_
*-isSemigroup : IsSemigroup *
distrib : * DistributesOver +
zero : Zero 0# *

https://github.com/Akshobhya1234/Agda-Algebra/blob/c358d3aa0179a9b6e287d2a06b184856b081d721/src/Structures.agda#L23-L28

@Taneb
Copy link
Member Author

Taneb commented Jan 15, 2022

@Akshobhya1234 yes, that looks right, but note the changes in #1684

@Akshobhya1234
Copy link
Contributor

@MatthewDaggitt or @Taneb I think we can close this issue. Or is there something that is still missing?

@MatthewDaggitt MatthewDaggitt linked a pull request Feb 3, 2022 that will close this issue
@MatthewDaggitt
Copy link
Contributor

Yes, you're right! I forgot to link the PR to the issue. Thanks for the heads up!

@MatthewDaggitt MatthewDaggitt added this to the v2.0 milestone Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants