Skip to content

Bool in Data.List #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mechvel opened this issue Apr 2, 2018 · 2 comments
Closed

Bool in Data.List #263

mechvel opened this issue Apr 2, 2018 · 2 comments
Assignees
@MatthewDaggitt
Labels
addition library-design low-hanging-fruit
Milestone
0.16

Comments

@mechvel
Copy link
Contributor

mechvel commented Apr 2, 2018

Data.List.Base has filter based on Decidable P (which I like),
but span, dropWhile and some others still base on Bool.
This looks strange.
@MatthewDaggitt MatthewDaggitt self-assigned this Apr 5, 2018
@MatthewDaggitt MatthewDaggitt added this to the 0.16 milestone Apr 5, 2018
@MatthewDaggitt
Copy link
Contributor

I agree. They should be changed to use predicates as well.

@MatthewDaggitt
Copy link
Contributor

Closed with 80d49dc. As with filter and partition left the boolean versions in to help backwards compatibility for those who are determined not to use the better versions.

@andreasabel andreasabel mentioned this issue Sep 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MatthewDaggitt MatthewDaggitt

Labels
addition library-design low-hanging-fruit
Projects
None yet
Milestone
0.16
Development

No branches or pull requests
2 participants
@mechvel @MatthewDaggitt