From dbbdec3f290e7b246a7e7054baa39858ca53b532 Mon Sep 17 00:00:00 2001 From: Rob Loach Date: Wed, 1 Apr 2015 17:39:32 -0400 Subject: [PATCH 1/3] feat(eslint): Add ESLint linting support --- linters/eslintrc | 44 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) create mode 100644 linters/eslintrc diff --git a/linters/eslintrc b/linters/eslintrc new file mode 100644 index 0000000000..4dcf426715 --- /dev/null +++ b/linters/eslintrc @@ -0,0 +1,44 @@ +env: + browser: true + node: true + amd: true + jquery: true + +rules: + no-new-object: 2 + no-reserved-keys: 2 + no-array-constructor: 2 + quotes: [2, "single"] + indent: [2, 2] + no-multi-str: 2 + no-multi-spaces: 2 + no-shadow-restricted-names: 2 + dot-notation: 2 + block-scoped-var: 2 + vars-on-top: 2 + no-unused-vars: 2 + eqeqeq: 2 + use-isnan: 2 + no-eq-null: 2 + brace-style: 2 + spaced-line-comment: 2 + valid-jsdoc: 2 + space-infix-ops: 2 + eol-last: 2 + padded-blocks: [2, "never"] + space-before-blocks: 2 + comma-dangle: [2, "never"] + comma-style: 2 + semi: [2, always] + semi-spacing: 2 + no-extra-boolean-cast: 2 + space-before-function-paren: [2, "never"] + no-spaced-func: 2 + no-wrap-func: 2 + camelcase: 2 + new-cap: 2 + consistent-this: [1, "_this"] + func-names: 2 + key-spacing: 2 + no-dupe-keys: 2 + strict: 2 From 3058e38d0157db360d4b513342455213e2642fe3 Mon Sep 17 00:00:00 2001 From: Rob Loach Date: Thu, 2 Apr 2015 12:36:42 -0400 Subject: [PATCH 2/3] fix(eslint): Remove amd and jquery from env --- linters/eslintrc | 2 -- 1 file changed, 2 deletions(-) diff --git a/linters/eslintrc b/linters/eslintrc index 4dcf426715..e90a6a11b6 100644 --- a/linters/eslintrc +++ b/linters/eslintrc @@ -1,8 +1,6 @@ env: browser: true node: true - amd: true - jquery: true rules: no-new-object: 2 From 87ea8909d851f1a56b6cb7173b73a15f4b2a5d5b Mon Sep 17 00:00:00 2001 From: Rob Loach Date: Sun, 5 Apr 2015 23:04:13 -0400 Subject: [PATCH 3/3] fix(one-var): Add one-var setting from @nkbt --- linters/eslintrc | 1 + 1 file changed, 1 insertion(+) diff --git a/linters/eslintrc b/linters/eslintrc index e90a6a11b6..fa9296ac90 100644 --- a/linters/eslintrc +++ b/linters/eslintrc @@ -33,6 +33,7 @@ rules: space-before-function-paren: [2, "never"] no-spaced-func: 2 no-wrap-func: 2 + one-var: [2, "never"] camelcase: 2 new-cap: 2 consistent-this: [1, "_this"]