@@ -31,7 +31,7 @@ def config(self, value: AbstractFileBasedSpec) -> None:
31
31
Note: FileBasedSource only requires the keys defined in the abstract config, whereas concrete implementations of StreamReader
32
32
will require keys that (for example) allow it to authenticate with the 3rd party.
33
33
34
- Therefore, concrete implementations of AbstractFileBasedStreamReader 's config setter should assert that `value` is of the correct
34
+ Therefore, concrete implementations of AbstractFileBasedStreamPermissionsReader's 's config setter should assert that `value` is of the correct
35
35
config type for that type of StreamReader.
36
36
"""
37
37
...
@@ -61,7 +61,7 @@ def load_identity_groups(self, logger: logging.Logger) -> Iterable[Dict[str, Any
61
61
This function should return the Identities in a determined "space" or "domain" where the file metadata (ACLs) are fetched and ACLs items (Identities) exists.
62
62
63
63
e.g.
64
- def load_identity_groups(self, logger: logging.Logger) -> Dict[str, Any]:
64
+ def load_identity_groups(self, logger: logging.Logger) -> Iterable[ Dict[str, Any] ]:
65
65
api_conn = some_api.conn(credentials=SOME_CREDENTIALS)
66
66
users_api = api_conn.users()
67
67
groups_api = api_conn.groups()
@@ -87,7 +87,7 @@ def file_permissions_schema(self) -> Dict[str, Any]:
87
87
88
88
e.g.
89
89
def file_permissions_schema(self) -> Dict[str, Any]:
90
- # you can also follow the patter we have for python connectors and have a json file and read from there e.g. schemas/identities.json
90
+ # you can also follow the pattern we have for python connectors and have a json file and read from there e.g. schemas/identities.json
91
91
return {
92
92
"type": "object",
93
93
"properties": {
@@ -113,7 +113,7 @@ def identities_schema(self) -> Dict[str, Any]:
113
113
114
114
e.g.
115
115
def identities_schema(self) -> Dict[str, Any]:
116
- # you can also follow the patter we have for python connectors and have a json file and read from there e.g. schemas/identities.json
116
+ # you can also follow the pattern we have for python connectors and have a json file and read from there e.g. schemas/identities.json
117
117
return {
118
118
"type": "object",
119
119
"properties": {
0 commit comments