Skip to content

Commit beb96e4

Browse files
committed
fix bug related to inability to scrape connector name from connector dir
1 parent cabe7c1 commit beb96e4

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

airbyte_cdk/test/standard_tests/docker_base.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -131,14 +131,14 @@ def test_docker_image_build_and_spec(
131131
connector_image_override: str | None,
132132
) -> None:
133133
"""Run `docker_image` acceptance tests."""
134-
connector_root = self.get_connector_root_dir()
134+
connector_root = self.get_connector_root_dir().absolute()
135135
metadata = MetadataFile.from_file(connector_root / "metadata.yaml")
136136

137137
connector_image: str | None = connector_image_override
138138
if not connector_image:
139139
tag = "dev-latest"
140140
connector_image = build_connector_image(
141-
connector_name=connector_root.name,
141+
connector_name=connector_root.absolute().name,
142142
connector_directory=connector_root,
143143
metadata=metadata,
144144
tag=tag,
@@ -192,7 +192,7 @@ def test_docker_image_build_and_check(
192192
if not connector_image:
193193
tag = "dev-latest"
194194
connector_image = build_connector_image(
195-
connector_name=connector_root.name,
195+
connector_name=connector_root.absolute().name,
196196
connector_directory=connector_root,
197197
metadata=metadata,
198198
tag=tag,
@@ -269,7 +269,7 @@ def test_docker_image_build_and_read(
269269

270270
tag = "dev-latest"
271271
connector_root = self.get_connector_root_dir()
272-
connector_name = connector_root.name
272+
connector_name = connector_root.absolute().name
273273
metadata = MetadataFile.from_file(connector_root / "metadata.yaml")
274274
connector_image: str | None = connector_image_override
275275
if not connector_image:

airbyte_cdk/utils/connector_paths.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -181,11 +181,11 @@ def find_connector_root(from_paths: list[Path]) -> Path:
181181
# Check if the manifest file exists in the current directory
182182
for parent in [path, *path.parents]:
183183
if (parent / METADATA_YAML).exists():
184-
return parent
184+
return parent.absolute()
185185
if (parent / MANIFEST_YAML).exists():
186-
return parent
186+
return parent.absolute()
187187
if (parent / ACCEPTANCE_TEST_CONFIG).exists():
188-
return parent
188+
return parent.absolute()
189189
if parent.name == "airbyte_cdk":
190190
break
191191

0 commit comments

Comments
 (0)