Skip to content

Commit f63f195

Browse files
author
Oleksandr Bazarnov
committed
updated
1 parent a308674 commit f63f195

File tree

1 file changed

+6
-10
lines changed

1 file changed

+6
-10
lines changed

airbyte_cdk/sources/declarative/models/base_model_with_deprecations.py

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def __init__(self, **data: Any) -> None:
5050
"""
5151
Show warnings for deprecated fields during component initialization.
5252
"""
53-
53+
# placeholder for deprecation logs
5454
self._deprecation_logs: List[AirbyteLogMessage] = []
5555

5656
model_fields = self.__fields__
@@ -81,7 +81,7 @@ def __getattribute__(self, name: str) -> Any:
8181
field_info.field_info.extra.get(DEPRECATED, False) if field_info else False
8282
)
8383
if is_deprecated_field:
84-
deprecation_message = field_info.extra.get(DEPRECATION_MESSAGE, "")
84+
deprecation_message = field_info.field_info.extra.get(DEPRECATION_MESSAGE, "")
8585
self._deprecated_warning(name, deprecation_message)
8686
except (AttributeError, KeyError):
8787
pass
@@ -96,17 +96,13 @@ def _deprecated_warning(self, field_name: str, message: str) -> None:
9696
message (str): Warning message to be displayed.
9797
"""
9898

99+
message = f"Component type: `{self.__class__.__name__}`. Field '{field_name}' is deprecated. {message}"
100+
99101
# Emit a warning message for deprecated fields (to stdout) (Python Default behavior)
100-
warnings.warn(
101-
f"Component type: `{self.__class__.__name__}`. Field '{field_name}' is deprecated. {message}",
102-
DeprecationWarning,
103-
)
102+
warnings.warn(message, DeprecationWarning)
104103

105104
# Add the deprecation message to the Airbyte log messages,
106105
# this logs are displayed in the Connector Builder.
107106
self._deprecation_logs.append(
108-
AirbyteLogMessage(
109-
level=Level.WARN,
110-
message=f"Component type: `{self.__class__.__name__}`. Field '{field_name}' is deprecated. {message}",
111-
),
107+
AirbyteLogMessage(level=Level.WARN, message=message),
112108
)

0 commit comments

Comments
 (0)