Skip to content

Commit fe55075

Browse files
committed
don't emit error trace and added comment
1 parent 8a79834 commit fe55075

File tree

2 files changed

+5
-22
lines changed

2 files changed

+5
-22
lines changed

airbyte_cdk/sources/declarative/concurrent_declarative_source.py

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -641,20 +641,12 @@ def _select_streams(
641641
if stream_instance:
642642
abstract_streams.append(stream_instance)
643643
else:
644+
# Previous behavior in the legacy synchronous CDK was to also raise an error TRACE message if
645+
# the source was configured with raise_exception_on_missing_stream=True. This was used on very
646+
# few sources like facebook-marketing and google-ads. We decided not to port this feature over,
647+
# but we can do so if we feel it necessary. With the current behavior,we should still result
648+
# in a partial failure since missing streams will be marked as INCOMPLETE.
644649
self._message_repository.emit_message(
645650
as_airbyte_message(configured_stream.stream, AirbyteStreamStatus.INCOMPLETE)
646651
)
647-
648-
missing_stream_exception = AirbyteTracedException(
649-
message="A stream listed in your configuration was not found in the source. Please check the logs for more "
650-
"details.",
651-
internal_message=(
652-
f"The stream '{configured_stream.stream.name}' in your connection configuration was not found in the source. "
653-
f"Refresh the schema in your replication settings and remove this stream from future sync attempts."
654-
),
655-
failure_type=FailureType.config_error,
656-
stream_descriptor=StreamDescriptor(name=configured_stream.stream.name),
657-
)
658-
self._message_repository.emit_message(missing_stream_exception.as_airbyte_message())
659-
660652
return abstract_streams

unit_tests/sources/declarative/test_concurrent_declarative_source.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1918,15 +1918,6 @@ def test_catalog_contains_missing_stream_in_source():
19181918
emitted_at=1735689600000.0,
19191919
),
19201920
),
1921-
AirbyteTracedException(
1922-
message="A stream listed in your configuration was not found in the source. Please check the logs for more "
1923-
"details.",
1924-
internal_message=(
1925-
"The stream 'missing' in your connection configuration was not found in the source. Refresh the schema in your replication settings and remove this stream from future sync attempts."
1926-
),
1927-
failure_type=FailureType.config_error,
1928-
stream_descriptor=StreamDescriptor(name="missing"),
1929-
).as_airbyte_message(stream_descriptor=StreamDescriptor(name="missing")),
19301921
]
19311922

19321923
catalog = ConfiguredAirbyteCatalog(

0 commit comments

Comments
 (0)