feat(generator): handle custom request escaping

Author: shortcuts

clients/algoliasearch-client-javascript/bundlesize.config.json

@@ -35,18 +35,6 @@
     {
       "path": "packages/recommend/dist/recommend.umd.browser.js",
       "maxSize": "3.80KB"
-    },
-    {
-      "path": "packages/client-common/dist/client-common.esm.node.js",
-      "maxSize": "5.25KB"
-    },
-    {
-      "path": "packages/requester-browser-xhr/dist/requester-browser-xhr.esm.node.js",
-      "maxSize": "900B"
-    },
-    {
-      "path": "packages/requester-node-http/dist/requester-node-http.esm.node.js",
-      "maxSize": "1.15KB"
     }
   ]
 }

generators/src/main/java/com/algolia/codegen/cts/AlgoliaCtsGenerator.java

@@ -163,12 +163,16 @@ public Map<String, Object> postProcessSupportingFileData(Map<String, Object> obj
   private Map<String, Request[]> loadCTS() throws JsonParseException, JsonMappingException, IOException, CTSException {
     TreeMap<String, Request[]> cts = new TreeMap<>();
     File dir = new File("tests/CTS/methods/requests/" + client);
+    File commonTestDir = new File("tests/CTS/methods/requests/common");
     if (!dir.exists()) {
       throw new CTSException("CTS not found at " + dir.getAbsolutePath(), true);
     }
     for (File f : dir.listFiles()) {
       cts.put(f.getName().replace(".json", ""), Json.mapper().readValue(f, Request[].class));
     }
+    for (File f : commonTestDir.listFiles()) {
+      cts.put(f.getName().replace(".json", ""), Json.mapper().readValue(f, Request[].class));
+    }
     return cts;
   }
 

templates/java/libraries/okhttp-gson/api.mustache

@@ -112,7 +112,7 @@ public class {{classname}} extends ApiClient {
 
         // create path and map variables
         String requestPath = "{{{path}}}"{{#pathParams}}
-            .replaceAll("\\{" + "{{baseName}}" + "\\}", this.escapeString({{{paramName}}}.toString())){{/pathParams}};
+            .replaceAll("\\{" + "{{baseName}}" + "\\}", {{#vendorExtensions.x-is-custom-request}}{{{paramName}}}.toString()){{/vendorExtensions.x-is-custom-request}}{{^vendorExtensions.x-is-custom-request}}this.escapeString({{{paramName}}}.toString())){{/vendorExtensions.x-is-custom-request}}{{/pathParams}};
 
         {{javaUtilPrefix}}List<Pair> queryParams = new {{javaUtilPrefix}}ArrayList<Pair>();
         {{javaUtilPrefix}}Map<String, String> headers = new {{javaUtilPrefix}}HashMap<String, String>();

templates/javascript/api-single.mustache

@@ -203,10 +203,8 @@ export function create{{capitalizedApiName}}Api(options: CreateClientOptions{{#h
       requestOptions?: RequestOptions
         ) : Promise<{{{returnType}}}> {
       const requestPath = '{{{path}}}'{{#pathParams}}.replace(
-      {{=<% %>=}}
-        '{<%baseName%>}',
-      <%={{ }}=%>
-        encodeURIComponent(String({{paramName}}))
+        {{=<% %>=}}'{<%baseName%>}',<%={{ }}=%>
+        {{#vendorExtensions.x-is-custom-request}}String({{paramName}}){{/vendorExtensions.x-is-custom-request}}{{^vendorExtensions.x-is-custom-request}}encodeURIComponent(String({{paramName}})){{/vendorExtensions.x-is-custom-request}}
       ){{/pathParams}};
       const headers: Headers = {};
       const queryParameters: QueryParameters = {};

templates/php/api.mustache

@@ -241,7 +241,7 @@ use {{invokerPackage}}\RetryStrategy\ClusterHosts;
         if (${{paramName}} !== null) {
             $resourcePath = str_replace(
                 '{' . '{{baseName}}' . '}',
-                ObjectSerializer::toPathValue(${{paramName}}),
+                {{#vendorExtensions.x-is-custom-request}}{{paramName}}{{/vendorExtensions.x-is-custom-request}}{{^vendorExtensions.x-is-custom-request}}ObjectSerializer::toPathValue(${{paramName}}){{/vendorExtensions.x-is-custom-request}},
                 $resourcePath
             );
         }