Skip to content

Autocomplete elements with combobox role are missing required children #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
colis opened this issue May 19, 2021 · 1 comment
Open

Comments

@colis
Copy link

colis commented May 19, 2021

Description

Running a Lighthouse scan on a page with the autocomplete element will produce the following warning under the Accessibility section:

Elements with an ARIA [role] that require children to contain a specific [role] are missing some or all of those required children.

Reproduction

Steps

  1. Go to https://www.algolia.com/doc/ui-libraries/autocomplete/introduction/what-is-autocomplete/
  2. Run a Lighthouse scan
  3. Scroll down to the Accessibility section
  4. See the warning

Expected behavior

No accessibility warnings.

Environment

  • OS: Ubuntu 21.04
  • Browser: Chrome 90.0.4430.212
  • Autocomplete version: 1.0.1
@colis colis changed the title Autocomplete with combobox role are missing required children Autocomplete elements with combobox role are missing required children May 19, 2021
@nathnhughes
Copy link

Can confirm that I'm experiencing this too and there seems to be no way to configure this in the code.

Screenshot 2022-01-27 at 10 15 07

Perhaps worth noting that I'm exclusively using detached mode (setting the detached breakpoint to 0px)?

Any update would be useful as it's bringing our lighthouse score down 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants