fix(tar): avoid expansion on gtar options parse

Thanks-to: David Zaslavsky <[email protected]>

Closes scop#152

Author: scop

completions/tar

@@ -79,21 +79,22 @@ __gtar_parse_help_opt()
 
 __gtar_parse_help_line()
 {
-    local i
-
-    for i in $1; do
-        case "$i" in
-            # regular options
-            --* | -*)
-                __gtar_parse_help_opt "$i" "$2"
-                ;;
-
-            # end once there is single non-option word
-            *)
-                break
-                ;;
-        esac
-    done
+    local -a tmp
+    while read -ra tmp; do
+        for i in "${tmp[@]}"; do
+            case "$i" in
+                # regular options
+                --* | -*)
+                    __gtar_parse_help_opt "$i" "$2"
+                    ;;
+
+                # end once there is single non-option word
+                *)
+                    break
+                    ;;
+            esac
+        done
+    done <<<"$1"
 }
 
 __gnu_tar_parse_help()

test/t/test_tar.py

@@ -5,17 +5,18 @@
 from conftest import assert_bash_exec
 
 
-@pytest.mark.bashcomp(ignore_env=r"^-declare -f _tar$")
+@pytest.mark.bashcomp(ignore_env=r"^-declare -f _tar$||shopt -. failglob")
 class TestTar:
     @pytest.fixture(scope="class")
     def gnu_tar(self, bash):
         got = assert_bash_exec(bash, "tar --version || :", want_output=True)
         if not re.search(r"\bGNU ", got):
             pytest.skip("Not GNU tar")
 
-    @pytest.mark.complete("tar ")
-    def test_1(self, completion):
+    @pytest.mark.complete("tar ", pre_cmds=("shopt -s failglob",))
+    def test_1(self, bash, completion):
         assert completion
+        assert_bash_exec(bash, "shopt -u failglob")
 
     # Test "f" when mode is not as first option
     @pytest.mark.complete("tar zfc ", cwd="tar")