Merge pull request scop#670 from akinomyoga/fix-failglob-for-_expand

Fix `_expand` for failglob

Author: scop

bash_completion

@@ -1209,7 +1209,7 @@ _expand()
             ;;
         ~*)
             _tilde "$cur" ||
-                eval COMPREPLY[0]="$(printf ~%q "${COMPREPLY[0]#\~}")"
+                eval "COMPREPLY[0]=$(printf ~%q "${COMPREPLY[0]#\~}")"
             return ${#COMPREPLY[@]}
             ;;
     esac

test/t/unit/test_unit_expand.py

@@ -1,6 +1,6 @@
 import pytest
 
-from conftest import assert_bash_exec
+from conftest import assert_bash_exec, bash_env_saved
 
 
 @pytest.mark.bashcomp(cmd=None, ignore_env=r"^[+-](cur|COMPREPLY)=")
@@ -21,6 +21,17 @@ def test_user_home_compreply(self, bash, user_home):
         )
         assert output.strip() == home
 
+    def test_user_home_compreply_failglob(self, bash, user_home):
+        user, home = user_home
+        with bash_env_saved(bash) as bash_env:
+            bash_env.shopt("failglob", True)
+            output = assert_bash_exec(
+                bash,
+                r'cur="~%s"; _expand; printf "%%s\n" "$COMPREPLY"' % user,
+                want_output=True,
+            )
+        assert output.strip() == home
+
     def test_user_home_cur(self, bash, user_home):
         user, home = user_home
         output = assert_bash_exec(