test: move shellcheck to pre-commit

Author: scop

.pre-commit-config.yaml

@@ -23,3 +23,14 @@ repos:
       - id: mypy
         exclude: completions/
         args: [--config-file=test/setup.cfg]
+  - repo: https://github.com/ryanrhee/shellcheck-py
+    rev: v0.7.0.1-1
+    hooks:
+      - id: shellcheck
+        args: [
+          -S, error, # https://github.com/koalaman/shellcheck/issues/1554
+          -f, gcc,
+        ]
+        types: [text]
+        files: ^(bash_completion|completions/.+|test/run*|.+\.sh(\.in)?)$
+        exclude: completions/Makefile.*$

.travis.yml

@@ -23,10 +23,6 @@ script:
       -e CI=true -e DIST=$DIST -e BSD=$BSD -e NETWORK=$NETWORK
       ${NETWORK:+--network $NETWORK}
       -t bash-completion:$DIST
-  - if test $DIST = tools; then
-      test/run-shellcheck -f gcc
-        bash_completion bash_completion.sh.in completions/!(Makefile*);
-    fi
 
 before_deploy:
   - docker start bash-completion

CONTRIBUTING.md

@@ -169,8 +169,7 @@ Also, please bare the following coding guidelines in mind:
   is intended to do, fixes issues it intends to fix, etc.
 
 - In addition to running the test suite, there are a few scripts in the test/
-  dir that catch some common issues, see and use for example runLint and
-  run-shellcheck.
+  dir that catch some common issues, see and use for example runLint.
 
 - File bugs, enhancement, and pull requests at GitHub,
   https://github.com/scop/bash-completion.