fix(dpkg): don't offer broken option completions ending with "-"

Author: scop

completions/dpkg

@@ -87,6 +87,10 @@ _dpkg()
     $split && return
 
     COMPREPLY=($(compgen -W '$(_parse_help "$1")' -- "$cur"))
+    for i in ${!COMPREPLY[*]}; do
+        # remove ones ending with a dash (known parse issue, hard to fix)
+        [[ ${COMPREPLY[i]} != *- ]] || unset 'COMPREPLY[i]'
+    done
     [[ ${COMPREPLY-} == *= ]] && compopt -o nospace
 } &&
     complete -F _dpkg dpkg dpkg-deb dpkg-query

test/t/test_dpkg.py

@@ -17,3 +17,7 @@ def test_3(self, completion):
     @pytest.mark.complete("dpkg -i dpkg/")
     def test_i_deb(self, completion):
         assert completion == "bash-completion-test-subject.deb"
+
+    @pytest.mark.complete("dpkg -")
+    def test_no_trailing_dash_options(self, completion):
+        assert not any(x.endswith("-") for x in completion)