Skip to content

Altair does not render 64 bit integers correctly #2181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
h-barthwal opened this issue Apr 22, 2023 · 2 comments · Fixed by #2183
Closed

Altair does not render 64 bit integers correctly #2181

h-barthwal opened this issue Apr 22, 2023 · 2 comments · Fixed by #2183

Comments

@h-barthwal
Copy link

h-barthwal commented Apr 22, 2023

Describe the bug
Larger 64 bit integers get truncated in Altair.

To Reproduce
I think this should be reproducible with any GraphQL API that returns 64 bit integers (larger than a certain value) in extensions section.

Expected behavior
The integer should be rendered as returned by the API.

Screenshots
image

The number underlined in RED gets rendered as 3902760572613809000. However, the API actually returns 3902760572613809272.

Desktop (please complete the following information):

  • OS: Windows

Additional context
I think this behavior has something to do with the GraphQL spec that does not support 64 bit integers. But I think the current behavior is a little misleading as it silently truncates the numbers (even in extensions section of the response). Can we start supporting 64 bit integers in Altair?

@imolorhe
Copy link
Collaborator

@imolorhe
Copy link
Collaborator

Thanks for reporting this! I'd look into it as soon as I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants