Skip to content

Commit 402e010

Browse files
committed
mt76: dma: use kzalloc instead of devm_kzalloc for txwi
dma unmap is already needed for cleanup anyway, so we don't need the extra tracking and can save a bit of memory here Signed-off-by: Felix Fietkau <[email protected]>
1 parent 9912a46 commit 402e010

File tree

1 file changed

+4
-2
lines changed
  • drivers/net/wireless/mediatek/mt76

1 file changed

+4
-2
lines changed

drivers/net/wireless/mediatek/mt76/dma.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ mt76_alloc_txwi(struct mt76_dev *dev)
1616
int size;
1717

1818
size = L1_CACHE_ALIGN(dev->drv->txwi_size + sizeof(*t));
19-
txwi = devm_kzalloc(dev->dev, size, GFP_ATOMIC);
19+
txwi = kzalloc(size, GFP_ATOMIC);
2020
if (!txwi)
2121
return NULL;
2222

@@ -73,9 +73,11 @@ mt76_free_pending_txwi(struct mt76_dev *dev)
7373
struct mt76_txwi_cache *t;
7474

7575
local_bh_disable();
76-
while ((t = __mt76_get_txwi(dev)) != NULL)
76+
while ((t = __mt76_get_txwi(dev)) != NULL) {
7777
dma_unmap_single(dev->dev, t->dma_addr, dev->drv->txwi_size,
7878
DMA_TO_DEVICE);
79+
kfree(mt76_get_txwi_ptr(dev, t));
80+
}
7981
local_bh_enable();
8082
}
8183

0 commit comments

Comments
 (0)