Stop warning when undefined property values are instrumented

Author: blazzy

CHANGELOG.md

@@ -1,10 +1,14 @@
+### 5.2.2 (March 29, 2019)
+
+* Stop warning when `undefined` property values are instrumented
+
 ### 5.2.1 (March 28, 2019)
 
 * Fix npm publish failure where built files were missing.
 
 ### 5.2.0 (March 28, 2019)
 
-* Stop warning when null property values are instrumented
+* Stop warning when `null` property values are instrumented
 * Allow for objects nested within arrays
 
 ### 5.0.0 (March 19, 2019)

Makefile

@@ -74,19 +74,19 @@ $(OUT): node_modules $(SRC) package.json rollup.config.js rollup.min.js
 #
 # Target for minified `amplitude-snippet.js` file.
 #
-$(SNIPPET_OUT): $(SRC) $(SNIPPET) version
+$(SNIPPET_OUT): $(SRC) $(SNIPPET)
 	@$(JSHINT) --verbose $(SNIPPET)
 	@$(MINIFY) $(SNIPPET) -m -b max-line-len=80,beautify=false | awk 'NF' > $(SNIPPET_OUT)
 
-$(SEGMENT_SNIPPET_OUT): $(SRC) $(SNIPPET) version
+$(SEGMENT_SNIPPET_OUT): $(SRC) $(SNIPPET)
 	@grep -Ev "\ba?s\b" $(SNIPPET) | $(MINIFY) -m -b max-line-len=80,beautify=false - \
 		| awk 'NF' > $(SEGMENT_SNIPPET_OUT)
 
 #
 # Target for `tests-build.js` file.
 #
 
-build: $(TESTS) $(OUT) $(SNIPPET_OUT) $(SEGMENT_SNIPPET_OUT) README.md
+build: $(TESTS) $(OUT) $(SNIPPET_OUT) $(SEGMENT_SNIPPET_OUT)
 	@$(ROLLUP) --config rollup.test.js
 	@$(ROLLUP) --config rollup.snippet-tests.js
 

README.md

@@ -11,7 +11,7 @@ Please see our [installation guide](https://amplitude.zendesk.com/hc/en-us/artic
 [![npm version](https://badge.fury.io/js/amplitude-js.svg)](https://badge.fury.io/js/amplitude-js)
 [![Bower version](https://badge.fury.io/bo/amplitude-js.svg)](https://badge.fury.io/bo/amplitude-js)
 
-[5.2.1 - Released on March 28, 2019](https://github.com/amplitude/Amplitude-JavaScript/releases/latest)
+[5.2.2 - Released on March 29, 2019](https://github.com/amplitude/Amplitude-JavaScript/releases/latest)
 
 
 # JavaScript SDK Reference #

package.json

@@ -1,7 +1,7 @@
 {
   "name": "amplitude-js",
   "author": "Amplitude <[email protected]>",
-  "version": "5.2.1",
+  "version": "5.2.2",
   "license": "MIT",
   "description": "Javascript library for Amplitude Analytics",
   "keywords": [

src/amplitude-snippet.js

@@ -2,10 +2,10 @@
   var amplitude = window.amplitude || {'_q':[],'_iq':{}};
   var as = document.createElement('script');
   as.type = 'text/javascript';
-  as.integrity = 'sha384-+ritBC3Uh0X9JjWcMcvcreVEixaFd4J31hRpBXl3d1WnAYLkpsNjj4ISxf5Oytx9';
+  as.integrity = 'sha384-d/yhnowERvm+7eCU79T/bYjOiMmq4F11ElWYLmt0ktvYEVgqLDazh4+gW9CKMpYW';
   as.crossOrigin = 'anonymous';
   as.async = true;
-  as.src = 'https://cdn.amplitude.com/libs/amplitude-5.2.1-min.gz.js';
+  as.src = 'https://cdn.amplitude.com/libs/amplitude-5.2.2-min.gz.js';
   as.onload = function() {if(!window.amplitude.runQueuedFunctions) {console.log('[Amplitude] Error: could not load SDK');}};
   var s = document.getElementsByTagName('script')[0];
   s.parentNode.insertBefore(as, s);

src/utils.js

@@ -133,14 +133,16 @@ var validateProperties = function validateProperties(properties) {
 };
 
 var invalidValueTypes = [
-  'nan', 'undefined', 'function', 'arguments', 'regexp', 'element'
+  'nan', 'function', 'arguments', 'regexp', 'element'
 ];
 
 var validatePropertyValue = function validatePropertyValue(key, value) {
   var valueType = type(value);
   if (invalidValueTypes.indexOf(valueType) !== -1) {
     log.warn('WARNING: Property key "' + key + '" with invalid value type ' + valueType + ', ignoring');
     value = null;
+  } else if (valueType === 'undefined') {
+    value = null;
   } else if (valueType === 'error') {
     value = String(value);
     log.warn('WARNING: Property key "' + key + '" with value type error, coercing to ' + value);