Skip to content

fix: Add missing setLibrary API to snippet distribution #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2021
Merged

fix: Add missing setLibrary API to snippet distribution #445

merged 1 commit into from
Nov 16, 2021

Conversation

jooohhn
Copy link
Contributor

@jooohhn jooohhn commented Nov 16, 2021 •
edited
Loading

Summary

Adds setLibrary to the list of stubbed snippet proxy methods (related to #443)

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

@jooohhn jooohhn requested a review from qingzhuozhen November 16, 2021 00:20
@jooohhn jooohhn merged commit ff44909 into main Nov 16, 2021
@jooohhn jooohhn deleted the fix-set-library-snippet branch November 16, 2021 06:23
github-actions bot pushed a commit that referenced this pull request Nov 16, 2021
@amplitude-sdk-bot
chore(release): 8.11.0 [skip ci]
6d115b1 
# [8.11.0](v8.10.0...v8.11.0) (2021-11-16)

### Bug Fixes

* add missing setLibrary API to snippet distribution ([#445](#445)) ([ff44909](ff44909))

### Features

* add esm entry point ([#440](#440)) ([3e98d50](3e98d50))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qingzhuozhen qingzhuozhen Awaiting requested review from qingzhuozhen

1 more reviewer

@yuhao900914 yuhao900914 yuhao900914 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jooohhn @yuhao900914 @qingzhuozhen