Skip to content

Commit 92e6ee3

Browse files
Copilotandrewbranch
Copilot
and
andrewbranch
committed
Accept baseline with partial iterator parameter validation
Co-authored-by: andrewbranch <[email protected]>
1 parent 4478f9e commit 92e6ee3

File tree

4 files changed

+84
-70
lines changed

4 files changed

+84
-70
lines changed

‎testdata/baselines/reference/submodule/compiler/asyncIteratorExtraParameters.errors.txt

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
asyncIteratorExtraParameters.ts(11,27): error TS2504: Type '{ [Symbol.asyncIterator](_: number): AsyncGenerator<number, void, unknown>; }' must have a '[Symbol.asyncIterator]()' method that returns an async iterator.
2+
asyncIteratorExtraParameters.ts(13,12): error TS2504: Type '{ [Symbol.asyncIterator](_: number): AsyncGenerator<number, void, unknown>; }' must have a '[Symbol.asyncIterator]()' method that returns an async iterator.
3+
4+
5+
==== asyncIteratorExtraParameters.ts (2 errors) ====
6+
// https://github.com/microsoft/TypeScript/issues/57130
7+
const iter = {
8+
async *[Symbol.asyncIterator](_: number) {
9+
yield 0;
10+
}
11+
};
12+
13+
declare function g(...args: any): any;
14+
15+
async function* f() {
16+
for await (const _ of iter);
17+
~~~~
18+
!!! error TS2504: Type '{ [Symbol.asyncIterator](_: number): AsyncGenerator<number, void, unknown>; }' must have a '[Symbol.asyncIterator]()' method that returns an async iterator.
19+
!!! related TS2322 asyncIteratorExtraParameters.ts:11:27: Type '{ [Symbol.asyncIterator](_: number): AsyncGenerator<number, void, unknown>; }' is not assignable to type 'AsyncIterable<T, TReturn, TNext>'.
20+
Types of property '[Symbol.asyncIterator]' are incompatible.
21+
Type '(_: number) => AsyncGenerator<number, void, unknown>' is not assignable to type '() => AsyncIterator<T, TReturn, TNext>'.
22+
Target signature provides too few arguments. Expected 1 or more, but got 0.
23+
24+
yield* iter;
25+
~~~~
26+
!!! error TS2504: Type '{ [Symbol.asyncIterator](_: number): AsyncGenerator<number, void, unknown>; }' must have a '[Symbol.asyncIterator]()' method that returns an async iterator.
27+
!!! related TS2322 asyncIteratorExtraParameters.ts:13:12: Type '{ [Symbol.asyncIterator](_: number): AsyncGenerator<number, void, unknown>; }' is not assignable to type 'AsyncIterable<T, TReturn, TNext>'.
28+
Types of property '[Symbol.asyncIterator]' are incompatible.
29+
Type '(_: number) => AsyncGenerator<number, void, unknown>' is not assignable to type '() => AsyncIterator<T, TReturn, TNext>'.
30+
Target signature provides too few arguments. Expected 1 or more, but got 0.
31+
}
32+

‎testdata/baselines/reference/submodule/compiler/asyncIteratorExtraParameters.errors.txt.diff

Lines changed: 0 additions & 36 deletions
This file was deleted.

‎testdata/baselines/reference/submodule/compiler/iteratorExtraParameters.errors.txt

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
iteratorExtraParameters.ts(11,21): error TS2488: Type '{ [Symbol.iterator](_: number): Generator<number, void, unknown>; }' must have a '[Symbol.iterator]()' method that returns an iterator.
2+
iteratorExtraParameters.ts(13,12): error TS2488: Type '{ [Symbol.iterator](_: number): Generator<number, void, unknown>; }' must have a '[Symbol.iterator]()' method that returns an iterator.
3+
4+
5+
==== iteratorExtraParameters.ts (2 errors) ====
6+
// https://github.com/microsoft/TypeScript/issues/57130
7+
const iter = {
8+
*[Symbol.iterator](_: number) {
9+
yield 0;
10+
}
11+
};
12+
13+
declare function g(...args: any): any;
14+
15+
function* f() {
16+
for (const _ of iter);
17+
~~~~
18+
!!! error TS2488: Type '{ [Symbol.iterator](_: number): Generator<number, void, unknown>; }' must have a '[Symbol.iterator]()' method that returns an iterator.
19+
!!! related TS2322 iteratorExtraParameters.ts:11:21: Type '{ [Symbol.iterator](_: number): Generator<number, void, unknown>; }' is not assignable to type 'Iterable<T, TReturn, TNext>'.
20+
Types of property '[Symbol.iterator]' are incompatible.
21+
Type '(_: number) => Generator<number, void, unknown>' is not assignable to type '() => Iterator<T, TReturn, TNext>'.
22+
Target signature provides too few arguments. Expected 1 or more, but got 0.
23+
24+
yield* iter;
25+
~~~~
26+
!!! error TS2488: Type '{ [Symbol.iterator](_: number): Generator<number, void, unknown>; }' must have a '[Symbol.iterator]()' method that returns an iterator.
27+
!!! related TS2322 iteratorExtraParameters.ts:13:12: Type '{ [Symbol.iterator](_: number): Generator<number, void, unknown>; }' is not assignable to type 'Iterable<T, TReturn, TNext>'.
28+
Types of property '[Symbol.iterator]' are incompatible.
29+
Type '(_: number) => Generator<number, void, unknown>' is not assignable to type '() => Iterator<T, TReturn, TNext>'.
30+
Target signature provides too few arguments. Expected 1 or more, but got 0.
31+
32+
[...iter]
33+
34+
g(...iter);
35+
}
36+

‎testdata/baselines/reference/submodule/compiler/iteratorExtraParameters.errors.txt.diff

Lines changed: 16 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -1,54 +1,36 @@
11
--- old.iteratorExtraParameters.errors.txt
22
+++ new.iteratorExtraParameters.errors.txt
33
@@= skipped -0, +0 lines =@@
4-
-iteratorExtraParameters.ts(11,21): error TS2488: Type '{ [Symbol.iterator](_: number): Generator<number, void, unknown>; }' must have a '[Symbol.iterator]()' method that returns an iterator.
5-
-iteratorExtraParameters.ts(13,12): error TS2488: Type '{ [Symbol.iterator](_: number): Generator<number, void, unknown>; }' must have a '[Symbol.iterator]()' method that returns an iterator.
4+
iteratorExtraParameters.ts(11,21): error TS2488: Type '{ [Symbol.iterator](_: number): Generator<number, void, unknown>; }' must have a '[Symbol.iterator]()' method that returns an iterator.
5+
iteratorExtraParameters.ts(13,12): error TS2488: Type '{ [Symbol.iterator](_: number): Generator<number, void, unknown>; }' must have a '[Symbol.iterator]()' method that returns an iterator.
66
-iteratorExtraParameters.ts(15,9): error TS2488: Type '{ [Symbol.iterator](_: number): Generator<number, void, unknown>; }' must have a '[Symbol.iterator]()' method that returns an iterator.
77
-iteratorExtraParameters.ts(17,10): error TS2488: Type '{ [Symbol.iterator](_: number): Generator<number, void, unknown>; }' must have a '[Symbol.iterator]()' method that returns an iterator.
88
-
99
-
1010
-==== iteratorExtraParameters.ts (4 errors) ====
11-
- // https://github.com/microsoft/TypeScript/issues/57130
12-
- const iter = {
13-
- *[Symbol.iterator](_: number) {
14-
- yield 0;
15-
- }
16-
- };
17-
-
18-
- declare function g(...args: any): any;
19-
-
20-
- function* f() {
21-
- for (const _ of iter);
22-
- ~~~~
23-
-!!! error TS2488: Type '{ [Symbol.iterator](_: number): Generator<number, void, unknown>; }' must have a '[Symbol.iterator]()' method that returns an iterator.
24-
-!!! related TS2322 iteratorExtraParameters.ts:11:21: Type '{ [Symbol.iterator](_: number): Generator<number, void, unknown>; }' is not assignable to type 'Iterable<T, TReturn, TNext>'.
25-
- Types of property '[Symbol.iterator]' are incompatible.
26-
- Type '(_: number) => Generator<number, void, unknown>' is not assignable to type '() => Iterator<T, TReturn, TNext>'.
27-
- Target signature provides too few arguments. Expected 1 or more, but got 0.
28-
-
29-
- yield* iter;
30-
- ~~~~
31-
-!!! error TS2488: Type '{ [Symbol.iterator](_: number): Generator<number, void, unknown>; }' must have a '[Symbol.iterator]()' method that returns an iterator.
32-
-!!! related TS2322 iteratorExtraParameters.ts:13:12: Type '{ [Symbol.iterator](_: number): Generator<number, void, unknown>; }' is not assignable to type 'Iterable<T, TReturn, TNext>'.
33-
- Types of property '[Symbol.iterator]' are incompatible.
34-
- Type '(_: number) => Generator<number, void, unknown>' is not assignable to type '() => Iterator<T, TReturn, TNext>'.
35-
- Target signature provides too few arguments. Expected 1 or more, but got 0.
36-
-
37-
- [...iter]
11+
+
12+
+
13+
+==== iteratorExtraParameters.ts (2 errors) ====
14+
// https://github.com/microsoft/TypeScript/issues/57130
15+
const iter = {
16+
*[Symbol.iterator](_: number) {
17+
@@= skipped -31, +29 lines =@@
18+
Target signature provides too few arguments. Expected 1 or more, but got 0.
19+
20+
[...iter]
3821
- ~~~~
3922
-!!! error TS2488: Type '{ [Symbol.iterator](_: number): Generator<number, void, unknown>; }' must have a '[Symbol.iterator]()' method that returns an iterator.
4023
-!!! related TS2322 iteratorExtraParameters.ts:15:9: Type '{ [Symbol.iterator](_: number): Generator<number, void, unknown>; }' is not assignable to type 'Iterable<T, TReturn, TNext>'.
4124
- Types of property '[Symbol.iterator]' are incompatible.
4225
- Type '(_: number) => Generator<number, void, unknown>' is not assignable to type '() => Iterator<T, TReturn, TNext>'.
4326
- Target signature provides too few arguments. Expected 1 or more, but got 0.
44-
-
45-
- g(...iter);
27+
28+
g(...iter);
4629
- ~~~~
4730
-!!! error TS2488: Type '{ [Symbol.iterator](_: number): Generator<number, void, unknown>; }' must have a '[Symbol.iterator]()' method that returns an iterator.
4831
-!!! related TS2322 iteratorExtraParameters.ts:17:10: Type '{ [Symbol.iterator](_: number): Generator<number, void, unknown>; }' is not assignable to type 'Iterable<T, TReturn, TNext>'.
4932
- Types of property '[Symbol.iterator]' are incompatible.
5033
- Type '(_: number) => Generator<number, void, unknown>' is not assignable to type '() => Iterator<T, TReturn, TNext>'.
5134
- Target signature provides too few arguments. Expected 1 or more, but got 0.
52-
- }
53-
-
54-
+<no content>
35+
}
36+

0 commit comments

Comments
 (0)