chore: angular 19 stuffs (untracked and imports array)

nartc · nartc · commit b986d97a255c · 2025-01-05T01:43:21.000-06:00
diff --git a/apps/astro-docs/src/components/soba/scene-graph.ts b/apps/astro-docs/src/components/soba/scene-graph.ts
@@ -6,7 +6,6 @@ import {
 	CUSTOM_ELEMENTS_SCHEMA,
 	DestroyRef,
 	inject,
-	untracked,
 	viewChild,
 	ViewContainerRef,
 } from '@angular/core';
@@ -50,10 +49,8 @@ export class SceneGraph {
 		let ref: ComponentRef<unknown>;
 
 		afterNextRender(() => {
-			untracked(() => {
-				ref = this.anchor().createComponent(this.sobaContent());
-				ref.changeDetectorRef.detectChanges();
-			});
+			ref = this.anchor().createComponent(this.sobaContent());
+			ref.changeDetectorRef.detectChanges();
 		});
 
 		inject(DestroyRef).onDestroy(() => {
diff --git a/apps/astro-docs/src/components/soba/wrapper.ts b/apps/astro-docs/src/components/soba/wrapper.ts
@@ -36,18 +36,15 @@ export class SobaWrapper {
 	performance = this.canvasOptionsStore.select('performance');
 
 	constructor() {
-		effect(
-			() => {
-				const sceneKey = this.scene();
+		effect(() => {
+			const sceneKey = this.scene();
 
-				const { scene, canvasOptions } = sceneKey.split('.').reduce((acc, cur) => {
-					return acc[cur];
-				}, scenes) as SceneOptions;
+			const { scene, canvasOptions } = sceneKey.split('.').reduce((acc, cur) => {
+				return acc[cur];
+			}, scenes) as SceneOptions;
 
-				this.sobaContent.set(scene);
-				if (canvasOptions) this.canvasOptionsStore.update(canvasOptions);
-			},
-			{ allowSignalWrites: true },
-		);
+			this.sobaContent.set(scene);
+			if (canvasOptions) this.canvasOptionsStore.update(canvasOptions);
+		});
 	}
 }
diff --git a/apps/kitchen-sink/src/app/cannon/chain/experience.ts b/apps/kitchen-sink/src/app/cannon/chain/experience.ts
@@ -20,7 +20,6 @@ import { NgtArgs, injectBeforeRender, injectStore } from 'angular-three';
 import { NgtcPhysics } from 'angular-three-cannon';
 import { injectBox, injectCylinder, injectSphere } from 'angular-three-cannon/body';
 import { injectConeTwist } from 'angular-three-cannon/constraint';
-import { NgtcDebug } from 'angular-three-cannon/debug';
 import { Color, ColorRepresentation, Mesh, Object3D } from 'three';
 
 interface Handle {
@@ -201,7 +200,7 @@ export class StaticHandle {
 			}
 		</ngtc-physics>
 	`,
-	imports: [NgtcPhysics, NgtcDebug, NgtArgs, PointerHandle, Chain, StaticHandle],
+	imports: [NgtcPhysics, NgtArgs, PointerHandle, Chain, StaticHandle],
 	changeDetection: ChangeDetectionStrategy.OnPush,
 	schemas: [CUSTOM_ELEMENTS_SCHEMA],
 	host: { class: 'chain-experience' },
diff --git a/apps/kitchen-sink/src/app/cannon/kinematic-cube/experience.ts b/apps/kitchen-sink/src/app/cannon/kinematic-cube/experience.ts
@@ -11,7 +11,6 @@ import { Triplet } from '@pmndrs/cannon-worker-api';
 import { NgtArgs, injectBeforeRender } from 'angular-three';
 import { NgtcPhysics } from 'angular-three-cannon';
 import { injectBox, injectPlane, injectSphere } from 'angular-three-cannon/body';
-import { NgtcDebug } from 'angular-three-cannon/debug';
 import { Color, InstancedMesh, Mesh } from 'three';
 import niceColors from '../../colors';
 
@@ -141,7 +140,7 @@ export class InstancedSpheres {
 			<app-instanced-spheres />
 		</ngtc-physics>
 	`,
-	imports: [InstancedSpheres, Box, Plane, NgtcPhysics, NgtArgs, NgtcDebug],
+	imports: [InstancedSpheres, Box, Plane, NgtcPhysics, NgtArgs],
 	schemas: [CUSTOM_ELEMENTS_SCHEMA],
 	changeDetection: ChangeDetectionStrategy.OnPush,
 	host: { class: 'kimenatic-experience' },
diff --git a/apps/kitchen-sink/src/app/cannon/monday-morning/experience.ts b/apps/kitchen-sink/src/app/cannon/monday-morning/experience.ts
@@ -1,4 +1,3 @@
-import { NgTemplateOutlet } from '@angular/common';
 import {
 	CUSTOM_ELEMENTS_SCHEMA,
 	ChangeDetectionStrategy,
@@ -72,7 +71,7 @@ function injectDragConstraint(ref: Signal<ElementRef<Object3D> | undefined>) {
 			<ng-content />
 		</ngts-rounded-box>
 	`,
-	imports: [NgtArgs, NgtsRoundedBox],
+	imports: [NgtsRoundedBox],
 	schemas: [CUSTOM_ELEMENTS_SCHEMA],
 	changeDetection: ChangeDetectionStrategy.OnPush,
 })
@@ -126,7 +125,7 @@ function double([x, y, z]: Readonly<Triplet>): Triplet {
 
 		<ng-content />
 	`,
-	imports: [Box, NgTemplateOutlet],
+	imports: [Box],
 	schemas: [CUSTOM_ELEMENTS_SCHEMA],
 	changeDetection: ChangeDetectionStrategy.OnPush,
 })
@@ -324,7 +323,6 @@ interface CupGLTF extends GLTF {
 			</ngt-group>
 		</ngt-group>
 	`,
-	imports: [NgtArgs],
 	schemas: [CUSTOM_ELEMENTS_SCHEMA],
 	changeDetection: ChangeDetectionStrategy.OnPush,
 })
@@ -352,7 +350,7 @@ export class Mug {
 		<app-box #leg4 [scale]="[0.5, 4, 0.5]" />
 		<app-mug />
 	`,
-	imports: [NgtArgs, Mug, Box],
+	imports: [Mug, Box],
 	schemas: [CUSTOM_ELEMENTS_SCHEMA],
 	changeDetection: ChangeDetectionStrategy.OnPush,
 })
diff --git a/apps/kitchen-sink/src/app/misc/aviator/collectible/collectible-coin.component.ts b/apps/kitchen-sink/src/app/misc/aviator/collectible/collectible-coin.component.ts
@@ -6,7 +6,7 @@ import {
 	inject,
 	viewChild,
 } from '@angular/core';
-import { injectBeforeRender, NgtArgs } from 'angular-three';
+import { injectBeforeRender } from 'angular-three';
 import { CylinderGeometry, Mesh, MeshPhongMaterial } from 'three';
 import { COIN_DISTANCE_TOLERANCE, COLOR_COINS } from '../constants';
 import { GameStore } from '../game.store';
@@ -39,7 +39,6 @@ const coinMaterial = new MeshPhongMaterial({
 	`,
 	schemas: [CUSTOM_ELEMENTS_SCHEMA],
 	changeDetection: ChangeDetectionStrategy.OnPush,
-	imports: [NgtArgs],
 	hostDirectives: [{ directive: Collectible, inputs: ['state'], outputs: ['stateChange'] }],
 	providers: [
 		{ provide: SPAWNABLE_DISTANCE_TOLERANCE, useValue: COIN_DISTANCE_TOLERANCE },
diff --git a/apps/kitchen-sink/src/app/misc/aviator/experience.ts b/apps/kitchen-sink/src/app/misc/aviator/experience.ts
@@ -9,7 +9,6 @@ import { CollectiblesStore } from './collectible/collectibles.store';
 import { DISTANCE_FOR_COINS_SPAWN, PLANE_DEFAULT_HEIGHT, RATIO_SPEED_DISTANCE, SEA_RADIUS } from './constants';
 import { GameStore } from './game.store';
 import { Lights } from './lights/lights';
-import { Sea } from './sea/sea';
 import { Sky } from './sky/sky';
 
 @Component({
@@ -60,7 +59,7 @@ import { Sky } from './sky/sky';
 	`,
 	schemas: [CUSTOM_ELEMENTS_SCHEMA],
 	changeDetection: ChangeDetectionStrategy.OnPush,
-	imports: [NgtArgs, Lights, Sea, NgtsOrbitControls, Sky, Airplane, CollectibleCoin, CollectiblePowerUp],
+	imports: [NgtArgs, Lights, /* Sea, */ NgtsOrbitControls, Sky, Airplane, CollectibleCoin, CollectiblePowerUp],
 })
 export class Experience {
 	private gameStore = inject(GameStore);
diff --git a/apps/kitchen-sink/src/app/misc/aviator/sky/cloud.ts b/apps/kitchen-sink/src/app/misc/aviator/sky/cloud.ts
@@ -7,7 +7,7 @@ import {
 	viewChild,
 	viewChildren,
 } from '@angular/core';
-import { injectBeforeRender, NgtArgs } from 'angular-three';
+import { injectBeforeRender } from 'angular-three';
 import { BoxGeometry, Mesh, MeshPhongMaterial, Object3D } from 'three';
 import { COLORS } from '../constants';
 
@@ -22,7 +22,6 @@ import { COLORS } from '../constants';
 	`,
 	schemas: [CUSTOM_ELEMENTS_SCHEMA],
 	changeDetection: ChangeDetectionStrategy.OnPush,
-	imports: [NgtArgs],
 })
 export class Cloud {
 	protected material = new MeshPhongMaterial({ color: COLORS.white });
diff --git a/apps/kitchen-sink/src/app/rapier/joints/joints.ts b/apps/kitchen-sink/src/app/rapier/joints/joints.ts
@@ -8,7 +8,7 @@ import {
 	viewChild,
 	viewChildren,
 } from '@angular/core';
-import { injectBeforeRender, NgtArgs, NgtVector3, NON_ROOT } from 'angular-three';
+import { injectBeforeRender, NgtVector3, NON_ROOT } from 'angular-three';
 import { injectPrismaticJoint, injectSphericalJoint, NgtrRigidBody, NgtrRigidBodyType } from 'angular-three-rapier';
 import { Quaternion, Vector3 } from 'three';
 
@@ -69,7 +69,7 @@ export class RopeJoint {
 	`,
 	schemas: [CUSTOM_ELEMENTS_SCHEMA],
 	changeDetection: ChangeDetectionStrategy.OnPush,
-	imports: [RopeSegment, NgtArgs, RopeJoint, NgtrRigidBody],
+	imports: [RopeSegment, RopeJoint],
 })
 export class Rope {
 	length = input.required<number>();
diff --git a/apps/kitchen-sink/src/app/soba/porsche/model.ts b/apps/kitchen-sink/src/app/soba/porsche/model.ts
@@ -1,4 +1,3 @@
-import { NgTemplateOutlet } from '@angular/common';
 import { ChangeDetectionStrategy, Component, computed, CUSTOM_ELEMENTS_SCHEMA, effect, input } from '@angular/core';
 import { applyProps, NgtArgs } from 'angular-three';
 import { injectGLTF } from 'angular-three-soba/loaders';
@@ -12,7 +11,7 @@ import { color } from './color';
 	`,
 	schemas: [CUSTOM_ELEMENTS_SCHEMA],
 	changeDetection: ChangeDetectionStrategy.OnPush,
-	imports: [NgtArgs, NgTemplateOutlet],
+	imports: [NgtArgs],
 })
 export class Model {
 	position = input([0, 0, 0]);
diff --git a/apps/kitchen-sink/src/app/soba/portal-shapes/experience.ts b/apps/kitchen-sink/src/app/soba/portal-shapes/experience.ts
@@ -1,9 +1,9 @@
 import { ChangeDetectionStrategy, Component, CUSTOM_ELEMENTS_SCHEMA, inject } from '@angular/core';
 import { NgtArgs } from 'angular-three';
 import { NgtrCuboidCollider, NgtrPhysics } from 'angular-three-rapier';
-import { NgtsCameraControls, NgtsOrbitControls } from 'angular-three-soba/controls';
+import { NgtsCameraControls } from 'angular-three-soba/controls';
 import { NgtsPreload } from 'angular-three-soba/misc';
-import { NgtsBounds, NgtsContactShadows, NgtsEnvironment, NgtsLightformer } from 'angular-three-soba/staging';
+import { NgtsContactShadows, NgtsEnvironment, NgtsLightformer } from 'angular-three-soba/staging';
 import { Experience as BasicExperience } from '../basic/experience';
 import { Experience as InstancedVertexColorsExperience } from '../instanced-vertex-colors/experience';
 import { Experience as InstancesExperience } from '../instances/exprience';
@@ -158,8 +158,6 @@ import { Letter } from './letter';
 		ShakyExperience,
 		InvertedStencilBufferExperience,
 		InstancesExperience,
-		NgtsBounds,
-		NgtsOrbitControls,
 	],
 	hostDirectives: [NgtsPreload],
 })
diff --git a/apps/kitchen-sink/src/app/soba/simple-sound-analyser/track.ts b/apps/kitchen-sink/src/app/soba/simple-sound-analyser/track.ts
@@ -11,7 +11,6 @@ import {
 } from '@angular/core';
 import { injectBeforeRender, NgtArgs } from 'angular-three';
 import { NgtsText } from 'angular-three-soba/abstractions';
-import { NgtsPivotControls } from 'angular-three-soba/gizmos';
 import { InstancedMesh, MeshBasicMaterial, Object3D, PlaneGeometry } from 'three';
 import { AudioStore } from './audio.store';
 
@@ -29,7 +28,7 @@ import { AudioStore } from './audio.store';
 	`,
 	schemas: [CUSTOM_ELEMENTS_SCHEMA],
 	changeDetection: ChangeDetectionStrategy.OnPush,
-	imports: [NgtArgs, NgtsText, NgtsPivotControls],
+	imports: [NgtArgs, NgtsText],
 })
 export class Track {
 	sound = input.required<'drums' | 'synth' | 'snare'>();
