Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Mini bug with alert #1523

Closed
bealtine opened this issue Jan 4, 2014 · 3 comments
Closed

Mini bug with alert #1523

bealtine opened this issue Jan 4, 2014 · 3 comments

Comments

@bealtine
Copy link

bealtine commented Jan 4, 2014

Attributes don't seem to work on alert component type='danger'
Plunk here:
http://plnkr.co/edit/JxAsDgDkxNIOdk8gKKlX?p=preview

@pkozlowski-opensource
Copy link
Member

type is an AngularJS expression that is evaluated as an expression against a scope. If you want to use a constant you need to quote it: http://plnkr.co/edit/7AaSSMFGULqcu0tr8xXV?p=preview

@bealtine
Copy link
Author

bealtine commented Jan 4, 2014

strange design choice for what is essentially a const but fair enough, your choice:). I've forked and I've merged my previously written bs3 directives with your ideas with lots of the bs3 "improvements" that are missing from the ng-ui templates. Good stuff I'll shadow what you do in the future and keep up the good work and thanks a million

@pkozlowski-opensource
Copy link
Member

@bealtine actually we are re-considering this design choice, see #1460

If you've got any improvements that you feel like would made sense in this project feel free to open PRs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants