-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Datepicker feature #315
Comments
@mikehaas763 I created a datepicker directive. You can see it here live in Action. http://plnkr.co/PQOWFO If the Popover directive would support loading external content, it would be an easy task to put the datepicker into the popup. You can support me for this functionality in this issue here: #220 (comment) :-) |
@mikehaas763 @jhiemer this would be awesome addition to the project! Of course a good PR would be accepted provided that it adheres to the project philosophy: https://github.com/angular-ui/bootstrap#project-philosophy Also it would be great to have contributions from people who believe in what we are doing here, want to be part of the team and extend / maintain things in the longer run. Going to close this issue for now as it is not actionable for me at this point, you can continue discussion in it though :-) |
@pkozlowski-opensource all right. :-) Perhaps a small question before you abandon this discussion. The current implementation uses moment.js, as the native date implementation of JavaScript is not that comfortable. Would that bother with the core principles of the Bootstrap UI project? So @mikehaas763 how are we going to proceed? |
I agree with @pkozlowski-opensource - this would be an awesome PR. @jhiemer We want to avoid external dependencies if at all possible. PS: I'm going to submit a PR for the |
@pkozlowski-opensource @jhiemer @joshdmiller Where are we at with this right now? Has any work begun anywhere? I was thinking about beginning it this weekend.. at least writing the tests for it. If someone has already started but wants help please do push a branch and I will help out. |
@mikehaas763 yup, the work is well advanced on this, see #366 for the details. @bekos did awesome job pushing this forward, you can guys collaborate. For a start code / functionality review would be very helpful. |
Is the bootstrap project only willing to implement features that are in twitter's bootstrap? If you are willing to implement other things that would probably fit in the context of the bootstrap project, I was thinking of creating a pure AngularJS datepicker. It would only depend on the twitter css. Would a PR for this be considered?
The text was updated successfully, but these errors were encountered: