Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Datepicker feature #315

Closed
mikehaas763 opened this issue Apr 11, 2013 · 6 comments
Closed

Datepicker feature #315

mikehaas763 opened this issue Apr 11, 2013 · 6 comments

Comments

@mikehaas763
Copy link

Is the bootstrap project only willing to implement features that are in twitter's bootstrap? If you are willing to implement other things that would probably fit in the context of the bootstrap project, I was thinking of creating a pure AngularJS datepicker. It would only depend on the twitter css. Would a PR for this be considered?

@jhiemer
Copy link

jhiemer commented Apr 11, 2013

@mikehaas763 I created a datepicker directive. You can see it here live in Action. http://plnkr.co/PQOWFO

If the Popover directive would support loading external content, it would be an easy task to put the datepicker into the popup. You can support me for this functionality in this issue here: #220 (comment) :-)

@pkozlowski-opensource
Copy link
Member

@mikehaas763 @jhiemer this would be awesome addition to the project! Of course a good PR would be accepted provided that it adheres to the project philosophy: https://github.com/angular-ui/bootstrap#project-philosophy

Also it would be great to have contributions from people who believe in what we are doing here, want to be part of the team and extend / maintain things in the longer run.

Going to close this issue for now as it is not actionable for me at this point, you can continue discussion in it though :-)

@jhiemer
Copy link

jhiemer commented Apr 11, 2013

@pkozlowski-opensource all right. :-) Perhaps a small question before you abandon this discussion. The current implementation uses moment.js, as the native date implementation of JavaScript is not that comfortable. Would that bother with the core principles of the Bootstrap UI project?

So @mikehaas763 how are we going to proceed?

@joshdmiller
Copy link
Contributor

I agree with @pkozlowski-opensource - this would be an awesome PR.

@jhiemer We want to avoid external dependencies if at all possible. moment.js is super handy but I think if we need to we can just replicate a limited subset of its functionality - even in a $moment service, if necessary - to make the logic more streamlined. If you guys want to take a stab using moment.js, we can take a look afterward and see what we'd have to change/add to make it work without it. Let me know how I can help.

PS: I'm going to submit a PR for the popover-template functionality today or tomorrow if that'll help.

@mikehaas763
Copy link
Author

@pkozlowski-opensource @jhiemer @joshdmiller Where are we at with this right now? Has any work begun anywhere? I was thinking about beginning it this weekend.. at least writing the tests for it. If someone has already started but wants help please do push a branch and I will help out.

@pkozlowski-opensource
Copy link
Member

@mikehaas763 yup, the work is well advanced on this, see #366 for the details. @bekos did awesome job pushing this forward, you can guys collaborate. For a start code / functionality review would be very helpful.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants