Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Support multiple position options for popover #4024

Closed
SMHFandA opened this issue Jul 27, 2015 · 6 comments
Closed

Support multiple position options for popover #4024

SMHFandA opened this issue Jul 27, 2015 · 6 comments

Comments

@SMHFandA
Copy link

Thanks very much, guys, for your jobs. Very useful module.

i have suggestions relatively popover component. Be nice if, maybe in future, popover component have following position settings: top-left, top-right, bottom-left, bottom-right. Something like this:

popover-bottom-left-position

Thanks.

@wesleycho
Copy link
Contributor

There are already multiple tickets on this - see my PR at #3900 for a preliminary implementation that would allow support of this feature.

@wesleycho wesleycho added this to the Backlog milestone Jul 27, 2015
@wesleycho wesleycho changed the title Adding new feature Support multiple position options for popover Jul 27, 2015
@ksheedlo
Copy link

+1 to this and for #3900.

One concern I want to raise here is that we may need to put the directions in different order to mean different things. For instance, the popover in the issue comment screenshot is to the right of the button and aligned with the bottom edge. I've mostly worked with popovers that are above or below the button and align with the sides. For example, this is what I would call a bottom-left popover.

screen shot 2015-08-26 at 2 18 24 pm

Since it is below the target element and aligned with the left edge. By this scheme, the popover in the issue screenshot would be a right-bottom popover, not a bottom-right.

@wesleycho
Copy link
Contributor

Please don't +1 issues - rest of the commentary is fine, just adding that to educate since it alone adds no valuable signal or information :) .

Thanks for that particular use case though - that is useful information for when we tackle this on full.

@ksheedlo
Copy link

Understood. BTW @wesleycho - is there anything I can do to help move the needle on this? My day job is stuck on an ancient forked version of ui-bootstrap and this is something we desperately need. I'd be glad to help out in whatever capacity.

@wesleycho
Copy link
Contributor

If you're willing to put in the legwork to implement it properly based on master with proper test coverage, we'd gladly accept pull requests.

@icfantv
Copy link
Contributor

icfantv commented Oct 28, 2015

Closing in favor of #4762.

@icfantv icfantv closed this as completed Oct 28, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants