Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

The new 0.14 version performance is even worse than before #1404

Closed
Avien opened this issue Jan 26, 2016 · 11 comments
Closed

The new 0.14 version performance is even worse than before #1404

Avien opened this issue Jan 26, 2016 · 11 comments

Comments

@Avien
Copy link

Avien commented Jan 26, 2016

Can someone address the performance issues?
I cant use this library

@user378230
Copy link
Contributor

Duplicate of #389 ?

@Avien
Copy link
Author

Avien commented Jan 28, 2016

Yep,
Also same as #1361
Very slow when opening,searching & removing, especially when there are multiple drop downs

I forked the project and did the changes I needed:
https://github.com/Avien/ui-select/tree/v0.13.4

@Narretz
Copy link
Contributor

Narretz commented Jan 29, 2016

@Avien dou should open a PR with your changes

@Avien
Copy link
Author

Avien commented Jan 31, 2016

My changes are specific to my needs, I doubt it would fit others
Its also a fork from 0.13.2 and not from the latest version

@SargoDarya
Copy link

Also with 183 Pull Requests open I don't think this will land anytime soon.

@Narretz
Copy link
Contributor

Narretz commented Feb 12, 2016

The maintainers need to set priorities. For example, looking at the state of the issue queue, there should be a stop on features for the time being. Solid tests, and performance and compatibility fixes should be prioritized.

@buremba
Copy link

buremba commented Feb 18, 2016

@Narretz +1. Currently, this component is the only stable select component for Angular but the performance issues prevent us to use it in our production environment.

@Avien
Copy link
Author

Avien commented Feb 25, 2016

So just upgraded to angular 1.5 and therefore needed to upgrade ui-select (0.14.3) to fix the transclude issue but the performance is awful!!
I cant search a multi select with 100 items , it is so slow, and also closing the menu is very slow
Unfortunately going back to my fork, and revert back to angular 1.4.x
Will have to find an alternative to ui-select

@Avien
Copy link
Author

Avien commented Feb 25, 2016

I have managed to create a fix on the latest version which omits the newly animation added to the menu, apparently it slows down the rendering significantly.
Also added the ability to know when the component is filtered by emitting a 'uis:filter' event
#1460

@jaxspades
Copy link

Yeah, can we get this put in place please?

@user378230
Copy link
Contributor

Closing in favour of #389 & #648

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants