Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

Remove .btn-default? #147

Closed
brettstack opened this issue Aug 7, 2014 · 5 comments
Closed

Remove .btn-default? #147

brettstack opened this issue Aug 7, 2014 · 5 comments

Comments

@brettstack
Copy link

If you use the standard, OOTB bootstrap build, ui-select looks fine. However, if you do a custom build that has .btn-default that has different colors to .form-control, ui-select begins to look out of place in forms. Can we consider removing the .btn-default class from the ui-select button?

@dimirc
Copy link
Contributor

dimirc commented Aug 8, 2014

If we remove that class, this will be the result:

With .btn-default
screen shot 2014-08-08 at 1 50 29 pm

Without .btn-default
screen shot 2014-08-08 at 1 50 41 pm

I don't think that without that class the result is ok, or do you mean something else?

@brettstack
Copy link
Author

I was initially going to suggest the removal of .btn as well, but didn't want to seem to extreme. ;) It's the .btn that's messing with the border. If we remove .btn and .btn-default, the result is ui-select looking just like a regular input field with a caret (which I think is the desired effect):
image

@dimirc
Copy link
Contributor

dimirc commented Aug 11, 2014

Ok, one thing that I also see if we remove them both, is that there won't be any hover effect. Though, not sure if this will actually be a problem to anybody.

screen shot 2014-08-10 at 9 03 18 pm
screen shot 2014-08-10 at 9 04 40 pm

@dimirc
Copy link
Contributor

dimirc commented Aug 11, 2014

@breandr check this PR #138
In this PR, we are using btn btn-default btn-xs classes for the buttons. Check the plunker

@dimirc
Copy link
Contributor

dimirc commented Sep 9, 2014

I don't see an easy way to remove that clases now, maybe you could just set your own styles directly on the <style> tag

@dimirc dimirc closed this as completed Sep 9, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants