Skip to content

Collection Extension / Merging #12713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasperbosch opened this issue Oct 23, 2018 · 3 comments
Closed

Collection Extension / Merging #12713

jasperbosch opened this issue Oct 23, 2018 · 3 comments
Labels
needs: more info Reporter must clarify the issue

Comments

@jasperbosch
Copy link

jasperbosch commented Oct 23, 2018

Bug Report or Feature Request (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request

Command (mark with an x)

- [ ] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [x] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions

Node v8.12.0
npm 6.4.1

Angular CLI: 7.0.2
Node: 8.12.0
OS: win32 x64
Angular: 7.0.0
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

Package Version

@angular-devkit/architect 0.10.2
@angular-devkit/build-angular 0.10.2
@angular-devkit/build-optimizer 0.10.2
@angular-devkit/build-webpack 0.10.2
@angular-devkit/core 7.0.2
@angular-devkit/schematics 7.0.2
@angular-devkit/schematics-cli 0.10.2
@angular/cli 7.0.2
@ngtools/webpack 7.0.2
@schematics/angular 7.0.2
@schematics/schematics 0.10.2

Repro steps

collections.json of @my-project/my-component

{
  "$schema": "./node_modules/@angular-devkit/schematics/collection-schema.json",
  "schematics": {
    "ng-add": {
      "extends" : "@my-project/schematics:my-component-install"
    }
  }
}

execute: ng add @my-project/my-component

The log given by the failure

Schematic "my-component-install" not found in collection "@my-project/my-component".

Desired functionality

See discussion on angular/devkit#34 .According to that discussion the extends should work. It did in Angular6!

Mention any other details that might be useful

Worked fine with Angular6.

@clydin
Copy link
Member

clydin commented Oct 23, 2018

From the error message, "@my-project/my-comonent" appears to have component misspelled.

@alan-agius4 alan-agius4 added the needs: more info Reporter must clarify the issue label Oct 25, 2018
@alan-agius4
Copy link
Collaborator

Thanks for reporting this issue. However, you didn't provide sufficient information for us to understand and reproduce the problem. Please check out our submission guidelines to understand why we can't act on issues that are lacking important information.

If the problem persists, please file a new issue and ensure you provide all of the required information when filling out the issue template.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: more info Reporter must clarify the issue
Projects
None yet
Development

No branches or pull requests

3 participants