From 8774b3473165dc83470e496dc8fb79ff4f4a0cd5 Mon Sep 17 00:00:00 2001 From: Alan Agius Date: Tue, 19 Mar 2019 11:04:49 +0100 Subject: [PATCH] fix(@angular-devkit/build-angular): update speed-measure-webpack-plugin to 1.3.1 This fixes the issue of it generating an empty `speed-measure-plugin.json`. Fixes #12763 --- packages/angular_devkit/build_angular/package.json | 2 +- .../build_angular/test/browser/profile_spec_large.ts | 7 +++++-- yarn.lock | 8 ++++---- 3 files changed, 10 insertions(+), 7 deletions(-) diff --git a/packages/angular_devkit/build_angular/package.json b/packages/angular_devkit/build_angular/package.json index 6beef2d3b4af..eb7f6e28214f 100644 --- a/packages/angular_devkit/build_angular/package.json +++ b/packages/angular_devkit/build_angular/package.json @@ -37,7 +37,7 @@ "semver": "5.6.0", "source-map-support": "0.5.10", "source-map-loader": "0.2.4", - "speed-measure-webpack-plugin": "1.3.0", + "speed-measure-webpack-plugin": "1.3.1", "stats-webpack-plugin": "0.7.0", "style-loader": "0.23.1", "stylus": "0.54.5", diff --git a/packages/angular_devkit/build_angular/test/browser/profile_spec_large.ts b/packages/angular_devkit/build_angular/test/browser/profile_spec_large.ts index e17349953549..e122852b31fd 100644 --- a/packages/angular_devkit/build_angular/test/browser/profile_spec_large.ts +++ b/packages/angular_devkit/build_angular/test/browser/profile_spec_large.ts @@ -7,7 +7,7 @@ */ import { runTargetSpec } from '@angular-devkit/architect/testing'; -import { normalize } from '@angular-devkit/core'; +import { normalize, virtualFs } from '@angular-devkit/core'; import { tap } from 'rxjs/operators'; import { browserTargetSpec, host } from '../utils'; @@ -21,8 +21,11 @@ describe('Browser Builder profile', () => { runTargetSpec(host, browserTargetSpec, overrides).pipe( tap((buildEvent) => expect(buildEvent.success).toBe(true)), tap(() => { + const speedMeasureLogPath = normalize('speed-measure-plugin.json'); expect(host.scopedSync().exists(normalize('chrome-profiler-events.json'))).toBe(true); - expect(host.scopedSync().exists(normalize('speed-measure-plugin.json'))).toBe(true); + expect(host.scopedSync().exists(speedMeasureLogPath)).toBe(true); + const content = virtualFs.fileBufferToString(host.scopedSync().read(speedMeasureLogPath)); + expect(content).toContain('plugins'); }), ).toPromise().then(done, done.fail); }); diff --git a/yarn.lock b/yarn.lock index 4e69d6a5ca36..dfe3d06911e3 100644 --- a/yarn.lock +++ b/yarn.lock @@ -9328,10 +9328,10 @@ spdy@^4.0.0: select-hose "^2.0.0" spdy-transport "^3.0.0" -speed-measure-webpack-plugin@1.3.0: - version "1.3.0" - resolved "https://registry.yarnpkg.com/speed-measure-webpack-plugin/-/speed-measure-webpack-plugin-1.3.0.tgz#c7ffafef513df3d63d5d546c8fc1986dfc4969aa" - integrity sha512-b9Yd0TrzceMVYSbuamM1sFsGM1oVfyFTM22gOoyLhymNvBVApuYpkdFOgYkKJpN/KhTpcCYcTGHg7X+FJ33Vvw== +speed-measure-webpack-plugin@1.3.1: + version "1.3.1" + resolved "https://registry.yarnpkg.com/speed-measure-webpack-plugin/-/speed-measure-webpack-plugin-1.3.1.tgz#69840a5cdc08b4638697dac7db037f595d7f36a0" + integrity sha512-qVIkJvbtS9j/UeZumbdfz0vg+QfG/zxonAjzefZrqzkr7xOncLVXkeGbTpzd1gjCBM4PmVNkWlkeTVhgskAGSQ== dependencies: chalk "^2.0.1"