Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

regression: incorrect scope isolation error #4439

Open
lhorie opened this issue Oct 15, 2013 · 3 comments
Open

regression: incorrect scope isolation error #4439

lhorie opened this issue Oct 15, 2013 · 3 comments

Comments

@lhorie
Copy link

lhorie commented Oct 15, 2013

If the root element of a directive configured to be {replace:true, scope: {}}, uses another directive that also creates a isolated scope, the $compile:multidir error gets thrown

http://plnkr.co/edit/J4zbrndV627ERZuicyQs?p=preview

Only happens in 1.2.rc3

@IgorMinar
Copy link
Contributor

this is legit bug and still repros with 1.2.7

http://plnkr.co/edit/65MwnNwJANgbZfasqXjc?p=preview

@Narretz Narretz modified the milestones: 1.3.0, Backlog Jul 3, 2014
@jeffbcross jeffbcross assigned jeffbcross and unassigned jeffbcross Jul 17, 2014
@jeffbcross jeffbcross modified the milestones: 1.3.0-beta.17, 1.3.0 Jul 21, 2014
@jeffbcross
Copy link
Contributor

Here are a few thoughts after some discussion with @petebacondarwin:

  • It's not clear from this use case what the expected scope provided to ng-controller element should be. The isolate scope? A child scope of the isolate?
  • Given that replace is deprecated, and given that this is an edge case, should it still be considered a valid bug?
  • In most cases, this could simply be circumvented by nesting the ng-controller directive one element deeper than at the root node of the template.

I suggest closing as invalid, unless @IgorMinar or anyone else has some insight into a better way to support this behavior.

@jeffbcross jeffbcross modified the milestones: Ice Box, 1.3.0-beta.17 Jul 21, 2014
@jeffbcross
Copy link
Contributor

Moved to icebox per IRL discussion with @IgorMinar, given low priority of this bug.

@jeffbcross jeffbcross removed their assignment Jul 23, 2014
@btford btford removed the gh: issue label Aug 20, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants