Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

src/components/textField/textField.spec.js out of date? #586

Closed
mlibby opened this issue Nov 9, 2014 · 2 comments
Closed

src/components/textField/textField.spec.js out of date? #586

mlibby opened this issue Nov 9, 2014 · 2 comments
Assignees
Milestone

Comments

@mlibby
Copy link
Contributor

mlibby commented Nov 9, 2014

As the spec file stands in master, the tests all pass.

But line 240 has a template like this

    md_input_group: '<div class="md-input-group" tabindex="-1">' +
                ' <label>{{label}}</label>' +
                ' <md-input id="{{id}}" type="{{type}}" ng-model="{{model}}"></md-input>' +
                '</div>'

This does not match the template in textField.js (line 74)

    '<md-input-group ng-disabled="isDisabled" tabindex="-1">' +
    ' <label for="{{fid}}" >{{label}}</label>' +
    ' <md-input id="{{fid}}" ng-model="value" type="{{inputType}}"></md-input>' +
    '</md-input-group>'

Using the second template causes two test to fail.

@ThomasBurleson
Copy link
Contributor

Also the tabindex is overwritten, regardless of pre-existing assignments.

@ThomasBurleson ThomasBurleson added this to the 0.7.0-rc1 milestone Nov 13, 2014
@ThomasBurleson ThomasBurleson self-assigned this Nov 13, 2014
@ajoslin ajoslin assigned marcysutton and unassigned ThomasBurleson Dec 3, 2014
@marcysutton marcysutton modified the milestones: 0.8.0, 0.7.0 Jan 5, 2015
@marcysutton
Copy link
Contributor

Closing as this now references deprecated code.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants