From dbbea657a0335cb2d9edbe3ad12c852705d19d8f Mon Sep 17 00:00:00 2001 From: mgechev Date: Fri, 23 Sep 2016 12:23:22 -0700 Subject: [PATCH] fix(app-shell): exclude private properties from package.json - Add `@types/node` in order to make sure we have the required node type definitions. - With `gulp-change` remove blacklisted properties from `package.json`. - Add `homepage` in `package.json`. --- app-shell/gulpfile.ts | 15 ++++++++++++--- app-shell/package.json | 5 +++-- 2 files changed, 15 insertions(+), 5 deletions(-) diff --git a/app-shell/gulpfile.ts b/app-shell/gulpfile.ts index 22ab223..8967b70 100644 --- a/app-shell/gulpfile.ts +++ b/app-shell/gulpfile.ts @@ -1,5 +1,3 @@ -declare var require; - const childProcess = require('child_process'); const commonjs = require('rollup-plugin-commonjs'); const gulp = require('gulp'); @@ -8,7 +6,7 @@ const rimraf = require('rimraf'); const rollup = require('rollup'); const nodeResolve = require('rollup-plugin-node-resolve'); const runSequence = require('run-sequence'); - +const change = require('gulp-change'); gulp.task('clean', done => { rimraf('./tmp', () => { @@ -103,8 +101,19 @@ gulp.task('task:bundles:deploy', () => gulp ], {base: 'tmp/es5'}) .pipe(gulp.dest('dist'))); +const updatePackage = (content: string) => { + const blacklist = [ + 'private', + 'devDependencies' + ]; + const parsed = JSON.parse(content); + blacklist.forEach(prop => delete parsed[prop]); + return JSON.stringify(parsed, null, 2); +}; + gulp.task('task:package:deploy', () => gulp .src([ 'package.json' ]) + .pipe(change(updatePackage)) .pipe(gulp.dest('dist'))); diff --git a/app-shell/package.json b/app-shell/package.json index 3528d9c..4dc2af2 100644 --- a/app-shell/package.json +++ b/app-shell/package.json @@ -17,9 +17,8 @@ "progressive web apps", "app shell" ], + "homepage": "https://mobile.angular.io", "license": "MIT", - "angular-cli": {}, - "scripts": {}, "main": "bundles/app-shell.umd.js", "module": "index.js", "private": true, @@ -33,7 +32,9 @@ "@angular/platform-browser-dynamic": "^2.0.0", "@angular/platform-server": "^2.0.0", "@types/jasmine": "^2.2.34", + "@types/node": "^6.0.41", "gulp": "^3.9.1", + "gulp-change": "^1.0.0", "gulp-jasmine": "^2.4.1", "reflect-metadata": "^0.1.8", "rimraf": "^2.5.4",