Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Make global.browser, global.$, etc., pass through to protractor.browser etc #3883

Closed
sjelin opened this issue Dec 27, 2016 · 1 comment
Closed

Make global.browser, global.$, etc., pass through to protractor.browser etc #3883

sjelin opened this issue Dec 27, 2016 · 1 comment
Assignees
@sjelin
Labels
difficulty: easy hotlist: polish type: cleanup type: enhancement

Comments

@sjelin
Copy link
Contributor

sjelin commented Dec 27, 2016

I'd rather only have one reference floating around. We can use Object.defineProperty() to make this work cleanly
@sjelin sjelin self-assigned this Dec 27, 2016
@sjelin
Copy link
Contributor Author

sjelin commented Jan 12, 2017

It's not worth it actually. The implementation adds more complexity than the existing situation. It kind of made sense in the context of #3884, but that's been closed anyway

@sjelin sjelin closed this as completed Jan 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sjelin sjelin

Labels
difficulty: easy hotlist: polish type: cleanup type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sjelin