Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Create private functions to do error messages in browser.ts #5043

Closed
cnishina opened this issue Nov 15, 2018 · 1 comment
Closed

Create private functions to do error messages in browser.ts #5043

cnishina opened this issue Nov 15, 2018 · 1 comment

Comments

@cnishina
Copy link
Contributor

Discussion and promise to do it in #5034 for the following

(line 655ish)

      if (timeout) {
        let errMsg = `Timed out waiting for asynchronous Angular tasks to finish after ` +
            `${timeout}. This may be because the current page is not an Angular ` +
            `application. Please see the FAQ for more details: ` +

and
(line 642ish)

      }, this.allScriptsTimeout, 'Plugins.waitForCondition()');
    } catch (err) {
      let timeout: RegExpExecArray;
      if (/asynchronous script timeout/.test(err.message)) {
@cnishina cnishina added this to the selenium4 upgrade milestone Nov 15, 2018
@cnishina cnishina self-assigned this Nov 15, 2018
@cnishina cnishina added the P2 label Nov 29, 2018
@cnishina
Copy link
Contributor Author

I'm not sure if there's a value add here. I would refactor by moving the error message out. It would make it a little more readable; however, this private method would only be used in one location. I am going to close this as a won't fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant