Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Move spec JavaScript files to TypeScript #5062

Open
cnishina opened this issue Nov 28, 2018 · 8 comments
Open

Move spec JavaScript files to TypeScript #5062

cnishina opened this issue Nov 28, 2018 · 8 comments

Comments

@cnishina
Copy link
Contributor

Placeholder.

@pittgoose
Copy link
Contributor

I'd love to contribute to this. Is this a matter of a straight conversion of test files from JS to TS? I could totally take this project.

@cnishina
Copy link
Contributor Author

Woo hoo! Thanks for volunteering!

This is going to not make this milestone since it was more of a wishlist type item. I am thinking we could be split between several of us: you, me, and @CrispusDH. I'll do something similar to #5017 where we have a list of test cases that need to be migrated.

I also want to have a PR that is a sample commit.... so let me do this first. I'm out at the end of the week for the holidays but maybe we do this in 2019?

@IgorSasovets
Copy link
Contributor

@cnishina , I'd also help to deal with it if needed.

@pittgoose
Copy link
Contributor

@cnishina Great! I'll keep an eye out for word from you.

@cnishina cnishina added P3 and removed P2 labels Dec 19, 2018
@simonua
Copy link
Contributor

simonua commented Jan 2, 2019

If there's a first-come, first-serve list of items to choose from, I might be able to contribute time and commits as well.

@cnishina
Copy link
Contributor Author

cnishina commented Jan 3, 2019

This is really exciting! Thank you everyone for your interest. Before we all jump on this.... let me come up with an example PR (I will have time on Friday)... It looks like we have 4 people. We'll divide up the work so we do not have duplicate PRs.

@simonua
Copy link
Contributor

simonua commented Jan 3, 2019

Thanks a ton for all your work on protractor, @cnishina!

@CrispusDH
Copy link
Contributor

@cnishina could you share plans? Several PRs waiting for review. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants