Skip to content

Commit 1d1d5ac

Browse files
authored
Add and fix units of TemperatureChangeRate (#1433)
added the following units to TemperatureChangeRate: DegreeFahrenheitPerMinute DegreeFahrenheitPerSecond DegreeKelvinPerSecond DegreeCelsiusPerHour DegreeKelvinPerHour DegreeFahrenheitPerHour After reviewing the unit tests I came to the conclusion that the recently added (#1429) unit DegreeKelvinPerMinute had a wrong conversion. I checked that for example here: https://www.unitsconverters.com/en/Rate-Of-Temperature-Change-Conversions/Measurement-1189 and also here: https://www.quora.com/Why-is-32-not-used-when-converting-per-degree-Celsius-C-1-to-per-degree-Fahrenheit-F-1
1 parent e32a276 commit 1d1d5ac

File tree

11 files changed

+636
-32
lines changed

11 files changed

+636
-32
lines changed

Common/UnitDefinitions/TemperatureChangeRate.json

Lines changed: 76 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,15 +35,89 @@
3535
{
3636
"SingularName": "DegreeKelvinPerMinute",
3737
"PluralName": "DegreesKelvinPerMinute",
38-
"FromUnitToBaseFunc": "({x} / 60) - 273.15",
39-
"FromBaseToUnitFunc": "({x} + 273.15) * 60",
38+
"FromUnitToBaseFunc": "{x} / 60",
39+
"FromBaseToUnitFunc": "{x} * 60",
4040
"Prefixes": [],
4141
"Localization": [
4242
{
4343
"Culture": "en-US",
4444
"Abbreviations": [ "K/min" ]
4545
}
4646
]
47+
},
48+
{
49+
"SingularName": "DegreeFahrenheitPerMinute",
50+
"PluralName": "DegreesFahrenheitPerMinute",
51+
"FromUnitToBaseFunc": "{x} * 5 / 9 / 60",
52+
"FromBaseToUnitFunc": "{x} * 9 / 5 * 60",
53+
"Localization": [
54+
{
55+
"Culture": "en-US",
56+
"Abbreviations": [ "°F/min" ]
57+
}
58+
]
59+
},
60+
{
61+
"SingularName": "DegreeFahrenheitPerSecond",
62+
"PluralName": "DegreesFahrenheitPerSecond",
63+
"FromUnitToBaseFunc": "{x} * 5 / 9",
64+
"FromBaseToUnitFunc": "{x} * 9 / 5",
65+
"Localization": [
66+
{
67+
"Culture": "en-US",
68+
"Abbreviations": [ "°F/s" ]
69+
}
70+
]
71+
},
72+
{
73+
"SingularName": "DegreeKelvinPerSecond",
74+
"PluralName": "DegreesKelvinPerSecond",
75+
"FromUnitToBaseFunc": "{x}",
76+
"FromBaseToUnitFunc": "{x}",
77+
"Prefixes": [],
78+
"Localization": [
79+
{
80+
"Culture": "en-US",
81+
"Abbreviations": [ "K/s" ]
82+
}
83+
]
84+
},
85+
{
86+
"SingularName": "DegreeCelsiusPerHour",
87+
"PluralName": "DegreesCelsiusPerHour",
88+
"FromUnitToBaseFunc": "{x} / 3600",
89+
"FromBaseToUnitFunc": "{x} * 3600",
90+
"Localization": [
91+
{
92+
"Culture": "en-US",
93+
"Abbreviations": [ "°C/h" ]
94+
}
95+
]
96+
},
97+
{
98+
"SingularName": "DegreeKelvinPerHour",
99+
"PluralName": "DegreesKelvinPerHour",
100+
"FromUnitToBaseFunc": "{x} / 3600",
101+
"FromBaseToUnitFunc": "{x} * 3600",
102+
"Prefixes": [],
103+
"Localization": [
104+
{
105+
"Culture": "en-US",
106+
"Abbreviations": [ "K/h" ]
107+
}
108+
]
109+
},
110+
{
111+
"SingularName": "DegreeFahrenheitPerHour",
112+
"PluralName": "DegreesFahrenheitPerHour",
113+
"FromUnitToBaseFunc": "{x} * 5 / 9 / 3600",
114+
"FromBaseToUnitFunc": "{x} * 9 / 5 * 3600",
115+
"Localization": [
116+
{
117+
"Culture": "en-US",
118+
"Abbreviations": [ "°F/h" ]
119+
}
120+
]
47121
}
48122
]
49123
}

Common/UnitEnumValues.g.json

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1452,7 +1452,13 @@
14521452
"MicrodegreeCelsiusPerSecond": 8,
14531453
"MillidegreeCelsiusPerSecond": 9,
14541454
"NanodegreeCelsiusPerSecond": 10,
1455-
"DegreeKelvinPerMinute": 20
1455+
"DegreeKelvinPerMinute": 20,
1456+
"DegreeCelsiusPerHour": 18,
1457+
"DegreeFahrenheitPerHour": 11,
1458+
"DegreeFahrenheitPerMinute": 16,
1459+
"DegreeFahrenheitPerSecond": 19,
1460+
"DegreeKelvinPerHour": 12,
1461+
"DegreeKelvinPerSecond": 15
14561462
},
14571463
"TemperatureDelta": {
14581464
"DegreeCelsius": 1,

UnitsNet.NanoFramework/GeneratedCode/Quantities/TemperatureChangeRate.g.cs

Lines changed: 80 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

UnitsNet.NanoFramework/GeneratedCode/Units/TemperatureChangeRateUnit.g.cs

Lines changed: 6 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

UnitsNet.NumberExtensions.Tests/GeneratedCode/NumberToTemperatureChangeRateExtensionsTest.g.cs

Lines changed: 24 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

UnitsNet.NumberExtensions/GeneratedCode/NumberToTemperatureChangeRateExtensions.g.cs

Lines changed: 48 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)