Skip to content

Mass.Parse Error on ToString(MassUnit.ShortTon) and ToString(MassUnit.LongTon) #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gojanpaolo opened this issue May 11, 2017 · 5 comments

Comments

@gojanpaolo
Copy link
Contributor

These lines throws an error:

Mass.Parse(new Mass().ToString(MassUnit.ShortTon));
Mass.Parse(new Mass().ToString(MassUnit.LongTon));

@angularsen
Copy link
Owner

Hi, thanks for pointing that out, I was not aware.
The culprit seems the regex that tries to extract value and unit from the string: https://github.com/anjdreas/UnitsNet/blob/master/UnitsNet/CustomCode/UnitParser.cs#L61

It currently reads any non-whitespace after the value as the unit, which means it only reads a single word. The units you posted have two word unit abbrevations; "short tn" and "long tn".

If you want to take a stab at fixing the regex, please do. If not I might find some time this weekend to look into this.

@gojanpaolo
Copy link
Contributor Author

Sure, I'll try doing it tomorrow.

@angularsen
Copy link
Owner

I didn't see you added the new commit, will review next week as I'm away.

@bplubell
Copy link
Contributor

bplubell commented Aug 3, 2017

I verified the issue @gojanpaolo was seeing has been resolved from #265, which is in release 3.68.

Mass.Parse(new Mass().ToString(MassUnit.ShortTon));
Mass.Parse(new Mass().ToString(MassUnit.LongTon));
no longer throw errors, but properly return the parsed Mass.

@angularsen
Copy link
Owner

Thanks, I also verified this just now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants