Skip to content

Commit 48627eb

Browse files
committed
drm/vc4: Fix a framebuffer reference leak on async flip interrupt.
We'd need X to queue up an async pageflip while another is outstanding, and then take a SIGIO. I think X actually avoids sending out the next pageflip while one's already queued, but I'm not sure. Signed-off-by: Eric Anholt <[email protected]>
1 parent 81f70ba commit 48627eb

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/gpu/drm/vc4/vc4_crtc.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -544,6 +544,7 @@ static int vc4_async_page_flip(struct drm_crtc *crtc,
544544
/* Make sure all other async modesetes have landed. */
545545
ret = down_interruptible(&vc4->async_modeset);
546546
if (ret) {
547+
drm_framebuffer_unreference(fb);
547548
kfree(flip_state);
548549
return ret;
549550
}

0 commit comments

Comments
 (0)