-
Notifications
You must be signed in to change notification settings - Fork 25
Follow semantic versioning (version X.Y.Z) #629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @GuillemBarroso, hi @jorgepiloto, I am not sure I understand the problem with having our master as X.Y.Z.devA. |
Hi @PProfizi, @jorgepiloto, correct me if I am wrong, but what I understood form the developers guide is that the agreed convention is:
meaning that the minor patch number (Z) for |
@GuillemBarroso I think this issue can be closed as not planned. |
Thank you for the clarification @PProfizi. @jorgepiloto, do you think we are going to run into some issues when integrating the pyansys/actions in PyDPF-Core? |
I was too fast opening this issue, sorry for this. @PProfizi is right. This version follows semantic versioning, so this issue can be closed. However, I would encourage to follow the "X.Y.dev0" for main, as this is what is being done by other libraries like PyMAPDL or PyAEDT. |
Thanks @jorgepiloto. Closing this issue. |
The syntax for this version does not follow semantic versioning, see dev guide. We should open an issue to address this in a separate pull-request, @GuillemBarroso. I know it was originally defined like this in the
setup.py
.Originally posted by @jorgepiloto in #627 (comment)
The text was updated successfully, but these errors were encountered: