Skip to content

[JS] comparison predicates don't work on 64-bit integers #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asfimport opened this issue Jul 6, 2018 · 6 comments
Open

[JS] comparison predicates don't work on 64-bit integers #122

asfimport opened this issue Jul 6, 2018 · 6 comments
Labels
Type: bug Something isn't working

Comments

@asfimport
Copy link

The 64-bit integer vector get function returns a 2-element array, which doesn't compare propery in the comparison predicates. We should special case the comparisons for 64-bit integers and timestamps.

Reporter: Brian Hulette / @TheNeuralBit

Note: This issue was originally created as ARROW-2797. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Taras Novak:
basically, we'd like to compare ints or find a better way to do this for Timestamps without conversion to Date for 100+K records. Probably same desire applies for other 64 bit packed ints.

the origins of this request: https://beta.observablehq.com/@randomfractals/apache-arrow

I'd like to optimize that without unpacking millisecs from epoch to dates. 

Create new Timestamp from a Date start/end filter example instead with arrow could probably do a trick for this perf. tuning bit, but I suspect there is more we should unpack there.

Thanks to @TheNeuralBit for collabo on this bit!

 

@asfimport
Copy link
Author

Neville Dipale / @nevi-me:
There's also apache/arrow#2358 which looks like the same issue.

@asfimport
Copy link
Author

Cameron Davison:
Just to keep in mind this will also affect Int128

@asfimport
Copy link
Author

Wes McKinney / @wesm:
Any thoughts about this for 0.14.0? @TheNeuralBit [~paul.e.taylor]

@asfimport
Copy link
Author

Brian Hulette / @TheNeuralBit:
Maybe if we only support this when we have BigInt it wouldn't be that big of a change?

@asfimport
Copy link
Author

Todd Farmer / @toddfarmer:
This issue was last updated over 90 days ago, which may be an indication it is no longer being actively worked. To better reflect the current state, the issue is being unassigned. Please feel free to re-take assignment of the issue if it is being actively worked, or if you plan to start that work soon.

@assignUser assignUser transferred this issue from apache/arrow May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant