Skip to content

Commit 6aaa15c

Browse files
committed
fix conflict
Signed-off-by: jayzhan211 <[email protected]>
1 parent cfffcbf commit 6aaa15c

File tree

3 files changed

+10
-6
lines changed

3 files changed

+10
-6
lines changed

datafusion/core/tests/user_defined/user_defined_aggregates.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -431,7 +431,7 @@ async fn test_user_defined_functions_with_alias() -> Result<()> {
431431
vec![DataType::Float64],
432432
Arc::new(DataType::Float64),
433433
Volatility::Immutable,
434-
Arc::new(|_| Ok(Box::<AvgAccumulator>::default())),
434+
Arc::new(|_, _, _| Ok(Box::<AvgAccumulator>::default())),
435435
Arc::new(vec![DataType::UInt64, DataType::Float64]),
436436
)
437437
.with_aliases(vec!["dummy_alias"]);

datafusion/expr/src/function.rs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,9 @@
1717

1818
//! Function module contains typing and signature for built-in and user defined functions.
1919
20-
use crate::{Accumulator, BuiltinScalarFunction, Expr, PartitionEvaluator, Signature};
21-
use crate::{AggregateFunction, BuiltInWindowFunction, ColumnarValue};
20+
use crate::ColumnarValue;
21+
use crate::{Accumulator, Expr, PartitionEvaluator};
2222
use arrow::datatypes::{DataType, Schema};
23-
use datafusion_common::utils::datafusion_strsim;
2423
use datafusion_common::Result;
2524
use std::sync::Arc;
2625

datafusion/expr/src/udaf.rs

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -355,8 +355,13 @@ impl AggregateUDFImpl for AliasedAggregateUDFImpl {
355355
self.inner.return_type(arg_types)
356356
}
357357

358-
fn accumulator(&self, arg: &DataType) -> Result<Box<dyn Accumulator>> {
359-
self.inner.accumulator(arg)
358+
fn accumulator(
359+
&self,
360+
arg: &DataType,
361+
sort_exprs: &[Expr],
362+
schema: &Schema,
363+
) -> Result<Box<dyn Accumulator>> {
364+
self.inner.accumulator(arg, sort_exprs, schema)
360365
}
361366

362367
fn state_type(&self, return_type: &DataType) -> Result<Vec<DataType>> {

0 commit comments

Comments
 (0)