feat: removed HPS because we can now use --expose_externalize_string to detect the encoding of a string. Additionally, we have submitted a PR to Node.js for detecting string encoding. If this PR is merged, we will be able to achieve good performance without this flag.

Author: theweipeng

LICENSE

@@ -272,11 +272,6 @@ The text of each license is also included in licenses/LICENSE-[project].txt.
       java/fury-core/src/main/java/org/apache/fury/type/Generics.java
       java/fury-core/src/test/java/org/apache/fury/type/GenericsTest.java
 
-* v8 (https://chromium.googlesource.com/v8/v8.git)
-    Files:
-      javascript/packages/hps/src/v8-fast-api-calls.h
-
-
 ================================================================
 MIT licenses
 ================================================================

ci/release.py

@@ -148,12 +148,6 @@ def bump_version(**kwargs):
                 new_version,
                 _update_js_version,
             )
-            _bump_version(
-                "javascript/packages/hps",
-                "package.json",
-                new_version,
-                _update_js_version,
-            )
         else:
             raise NotImplementedError(f"Unsupported {lang}")
 

docs/guide/xlang_serialization_guide.md

@@ -98,14 +98,7 @@ func main() {
 ```javascript
 import Fury from '@furyjs/fury';
 
-/**
- * @furyjs/hps use v8's fast-calls-api that can be called directly by jit, ensure that the version of Node is 20 or above.
- * Experimental feature, installation success cannot be guaranteed at this moment
- * If you are unable to install the module, replace it with `const hps = null;`
- **/
-import hps from '@furyjs/hps';
-
-const fury = new Fury({ hps });
+const fury = new Fury({});
 const input = fury.serialize('hello fury');
 const result = fury.deserialize(input);
 console.log(result);
@@ -317,18 +310,11 @@ func main() {
 ```javascript
 import Fury, { Type, InternalSerializerType } from '@furyjs/fury';
 
-/**
- * @furyjs/hps use v8's fast-calls-api that can be called directly by jit, ensure that the version of Node is 20 or above.
- * Experimental feature, installation success cannot be guaranteed at this moment
- * If you are unable to install the module, replace it with `const hps = null;`
- **/
-import hps from '@furyjs/hps';
-
 // Now we describe data structures using JSON, but in the future, we will use more ways.
 const description = Type.object('example.foo', {
   foo: Type.string(),
 });
-const fury = new Fury({ hps });
+const fury = new Fury({});
 const { serialize, deserialize } = fury.registerSerializer(description);
 const input = serialize({ foo: 'hello fury' });
 const result = deserialize(input);
@@ -490,19 +476,13 @@ func main() {
 
 ```javascript
 import Fury, { Type } from '@furyjs/fury';
-/**
- * @furyjs/hps use v8's fast-calls-api that can be called directly by jit, ensure that the version of Node is 20 or above.
- * Experimental feature, installation success cannot be guaranteed at this moment
- * If you are unable to install the module, replace it with `const hps = null;`
- **/
-import hps from '@furyjs/hps';
 
 const description = Type.object('example.foo', {
   foo: Type.string(),
   bar: Type.object('example.foo'),
 });
 
-const fury = new Fury({ hps });
+const fury = new Fury({});
 const { serialize, deserialize } = fury.registerSerializer(description);
 const data: any = {
   foo: 'hello fury',

javascript/README.md

@@ -8,26 +8,18 @@ The Cross-Language part of the protocol is not stable, so the output of this lib
 
 ```shell
 npm install @furyjs/fury
-npm install @furyjs/hps
 ```
 
 ## Usage
 
 ```Javascript
 import Fury, { Type, InternalSerializerType } from '@furyjs/fury';
 
-/**
- * @furyjs/hps use v8's fast-calls-api that can be called directly by jit, ensure that the version of Node is 20 or above.
- * Experimental feature, installation success cannot be guaranteed at this moment
- * If you are unable to install the module, replace it with `const hps = null;`
- **/
-import hps from '@furyjs/hps';
-
 // Now we describe data structures using JSON, but in the future, we will use more ways.
 const description = Type.object('example.foo', {
   foo: Type.string(),
 });
-const fury = new Fury({ hps });
+const fury = new Fury({});
 const { serialize, deserialize } = fury.registerSerializer(description);
 const input = serialize({ foo: 'hello fury' });
 const result = deserialize(input);
@@ -39,11 +31,3 @@ console.log(result);
 ### fury
 
 Fury protocol implementation. It generates JavaScript code at runtime to make sure that all the code could be optimized by v8 JIT efficiently.
-
-### hps
-
-Node.js high-performance suite, ensuring that your Node.js version is 20 or later.
-
-`hps` is use for detect the string type in v8. Fury support latin1 and utf8 string both, we should get the certain type of string before write it
-in buffer. It is slow to detect the string is latin1 or utf8, but hps can detect it by a hack way, which is called FASTCALL in v8.
-so it is not stable now.

javascript/benchmark/index.js

@@ -19,8 +19,7 @@
 
 const Fury = require("@furyjs/fury");
 const utils = require("@furyjs/fury/dist/lib/util");
-const hps = require('@furyjs/hps');
-const fury = new Fury.default({ hps, refTracking: false, useSliceString: true });
+const fury = new Fury.default({ refTracking: false, useSliceString: true });
 const Benchmark = require("benchmark");
 const protobuf = require("protobufjs");
 const path = require('path');

javascript/benchmark/map.js

@@ -19,9 +19,8 @@
 
 const Fury = require("@furyjs/fury");
 const beautify = require("js-beautify");
-const hps = require('@furyjs/hps');
 const fury = new Fury.default({
-  hps, refTracking: false, useSliceString: true, hooks: {
+  refTracking: false, useSliceString: true, hooks: {
     afterCodeGenerated: (code) => {
       return beautify.js(code, { indent_size: 2, space_in_empty_paren: true, indent_empty_lines: true });
     }

javascript/jest.config.js

@@ -19,10 +19,9 @@
 
 /** @type {import('ts-jest').JestConfigWithTsJest} */
 const semver = require("semver");
-const hpsEnable = semver.gt(process.versions.node, '20.0.0') && process.platform !== 'win32';
 
 module.exports = {
-  collectCoverage: hpsEnable,
+  collectCoverage: true,
   preset: 'ts-jest',
   testEnvironment: 'node',
   collectCoverageFrom: [
@@ -31,9 +30,6 @@ module.exports = {
     "!**/build/**",
     "!packages/fury/lib/murmurHash3.ts"
   ],
-  "testPathIgnorePatterns" : [
-    hpsEnable ? null : "(.*)/hps.test.ts$",
-  ].filter(Boolean),
   transform: {
     '\\.ts$': ['ts-jest', {
       tsconfig: {

javascript/package.json

@@ -1,14 +1,13 @@
 {
   "scripts": {
-    "test": "npm run build && jest",
-    "clear": "rm -rf ./packages/fury/dist && rm -rf ./packages/hps/dist",
-    "build": "npm run clear && npm run build -w packages/fury -w packages/hps",
+    "test": "npm run build && jest && node --expose_externalize_string node_modules/.bin/jest",
+    "clear": "rm -rf ./packages/fury/dist",
+    "build": "npm run clear && npm run build -w packages/fury",
     "lint": "eslint .",
     "lint-fix": "eslint . --fix"
   },
   "repository": "[email protected]:apache/fury.git",
   "workspaces": [
-    "packages/hps",
     "packages/fury"
   ],
   "devDependencies": {

javascript/packages/fury/lib/type.ts

@@ -95,18 +95,12 @@ export const HalfMinInt32 = MinInt32 / 2;
 export const LATIN1 = 0;
 export const UTF8 = 1;
 
-export interface Hps {
-  isLatin1: (str: string) => boolean;
-  stringCopy: (str: string, dist: Uint8Array, offset: number) => void;
-}
-
 export enum Mode {
   SchemaConsistent,
   Compatible,
 }
 
 export interface Config {
-  hps?: Hps;
   refTracking?: boolean;
   useSliceString?: boolean;
   hooks?: {

javascript/packages/fury/lib/writer/index.ts

@@ -22,6 +22,11 @@ import { PlatformBuffer, alloc, strByteLength } from "../platformBuffer";
 import { OwnershipError } from "../error";
 import { toFloat16 } from "./number";
 
+declare global {
+  // eslint-disable-next-line
+  var isOneByteString: ((input: string) => boolean) | undefined;
+}
+
 const MAX_POOL_SIZE = 1024 * 1024 * 3; // 3MB
 
 export class BinaryWriter {
@@ -32,12 +37,10 @@ export class BinaryWriter {
   private reserved = 0;
   private locked = false;
   private config: Config;
-  private hpsEnable = false;
 
   constructor(config: Config) {
     this.initPoll();
     this.config = config;
-    this.hpsEnable = Boolean(config?.hps);
   }
 
   private initPoll() {
@@ -188,14 +191,13 @@ export class BinaryWriter {
   }
 
   stringOfVarUInt32Fast(v: string) {
-    const { isLatin1: detectIsLatin1, stringCopy } = this.config.hps!;
-    const isLatin1 = detectIsLatin1(v);
+    const isLatin1 = globalThis.isOneByteString!(v);
     const len = isLatin1 ? v.length : strByteLength(v);
     this.dataView.setUint8(this.cursor++, isLatin1 ? LATIN1 : UTF8);
     this.varUInt32(len);
     this.reserve(len);
     if (isLatin1) {
-      stringCopy(v, this.platformBuffer, this.cursor);
+      this.platformBuffer.write(v, this.cursor, "latin1");
     } else {
       if (len < 40) {
         this.fastWriteStringUtf8(v, this.platformBuffer, this.cursor);
@@ -335,7 +337,7 @@ export class BinaryWriter {
   }
 
   stringOfVarUInt32(v: string) {
-    return this.hpsEnable
+    return globalThis.isOneByteString
       ? this.stringOfVarUInt32Fast(v)
       : this.stringOfVarUInt32Slow(v);
   }

javascript/packages/fury/package.json

@@ -25,6 +25,5 @@
   },
   "repository": "[email protected]:apache/fury.git",
   "workspaces": [
-    "packages/hps"
   ]
 }