Skip to content

Commit 7f176d0

Browse files
authored
HDFS-16729. RBF: fix some unreasonably annotated docs. (#4745)
Reviewed-by: Inigo Goiri <[email protected]> Signed-off-by: Akira Ajisaka <[email protected]>
1 parent c870171 commit 7f176d0

File tree

9 files changed

+13
-13
lines changed

9 files changed

+13
-13
lines changed

hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/Router.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -757,7 +757,7 @@ public ActiveNamenodeResolver getNamenodeResolver() {
757757
/**
758758
* Get the state store interface for the router heartbeats.
759759
*
760-
* @return FederationRouterStateStore state store API handle.
760+
* @return RouterStore state store API handle.
761761
*/
762762
public RouterStore getRouterStateManager() {
763763
if (this.routerStateManager == null && this.stateStore != null) {

hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/MembershipStore.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
* StateStoreDriver}, NameNode registrations are cached until the next query.
4949
* The fetched registration data is aggregated using a quorum to determine the
5050
* best/most accurate state for each NameNode. The cache is periodically updated
51-
* by the @{link StateStoreCacheUpdateService}.
51+
* by the {@link StateStoreCacheUpdateService}.
5252
*/
5353
@InterfaceAudience.Private
5454
@InterfaceStability.Evolving

hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreZooKeeperImpl.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@
5050
* |--- MEMBERSHIP
5151
* |--- REBALANCER
5252
* |--- ROUTERS
53+
* |--- DISABLE_NAMESERVICE
5354
*/
5455
public class StateStoreZooKeeperImpl extends StateStoreSerializableImpl {
5556

hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/package-info.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,19 +31,21 @@
3131
* StateStoreDriver} to handle querying, updating and deleting data records. The
3232
* data storage driver is initialized and maintained by the {@link
3333
* org.apache.hadoop.hdfs.server.federation.store.StateStoreService
34-
* FederationStateStoreService}. The state store
34+
* StateStoreService}. The state store
3535
* supports fetching all records of a type, filtering by column values or
3636
* fetching a single record by its primary key.
3737
* <p>
3838
* The state store contains several API interfaces, one for each data records
3939
* type.
4040
* <ul>
41-
* <li>FederationMembershipStateStore: state of all Namenodes in the federation.
41+
* <li>MembershipStore: state of all Namenodes in the federation.
4242
* Uses the MembershipState record.
43-
* <li>FederationMountTableStore: Mount table mapping paths in the global
43+
* <li>MountTableStore: Mount table mapping paths in the global
4444
* namespace to individual subcluster paths. Uses the MountTable record.
45-
* <li>RouterStateStore: State of all routers in the federation. Uses the
45+
* <li>RouterStore: State of all routers in the federation. Uses the
4646
* RouterState record.
47+
* <li>DisabledNameserviceStore: state of all disabled nameservice in the federation.
48+
* Uses the DisabledNameservice record.
4749
* </ul>
4850
* Each API is defined in a separate interface. The implementations of these
4951
* interfaces are responsible for accessing the {@link

hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/records/MembershipState.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
/**
3333
* Data schema for storing NN registration information in the
3434
* {@link org.apache.hadoop.hdfs.server.federation.store.StateStoreService
35-
* FederationStateStoreService}.
35+
* StateStoreService}.
3636
*/
3737
public abstract class MembershipState extends BaseRecord
3838
implements FederationNamenodeContext {

hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/records/MountTable.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,9 @@
4242
/**
4343
* Data schema for {@link
4444
* org.apache.hadoop.hdfs.server.federation.store.MountTableStore
45-
* FederationMountTableStore} data stored in the {@link
45+
* MountTableStore} data stored in the {@link
4646
* org.apache.hadoop.hdfs.server.federation.store.StateStoreService
47-
* FederationStateStoreService}. Supports string serialization.
47+
* StateStoreService}. Supports string serialization.
4848
*/
4949
public abstract class MountTable extends BaseRecord {
5050

hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/records/RouterState.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
* Entry to log the state of a
3232
* {@link org.apache.hadoop.hdfs.server.federation.router.Router Router} in the
3333
* {@link org.apache.hadoop.hdfs.server.federation.store.StateStoreService
34-
* FederationStateStoreService}.
34+
* StateStoreService}.
3535
*/
3636
public abstract class RouterState extends BaseRecord {
3737

hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/store/TestStateStoreMembershipState.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -586,8 +586,6 @@ private MembershipState getExpiredNamenodeRegistration(
586586
/**
587587
* Register a namenode heartbeat with the state store.
588588
*
589-
* @param store FederationMembershipStateStore instance to retrieve the
590-
* membership data records.
591589
* @param namenode A fully populated namenode membership record to be
592590
* committed to the data store.
593591
* @return True if successful, false otherwise.

hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/store/TestStateStoreMountTable.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,6 @@ private MountTable getMountTableEntry(String mount) throws IOException {
227227
/**
228228
* Fetch all mount table records beneath a root path.
229229
*
230-
* @param store FederationMountTableStore instance to commit the data.
231230
* @param mount The root search path, enter "/" to return all mount table
232231
* records.
233232
*

0 commit comments

Comments
 (0)