YARN-11228. Fix CheckStyle.

Author: slfan1989

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/RouterServerUtil.java

@@ -45,14 +45,14 @@ private RouterServerUtil() {
   /**
    * Throws an exception due to an error.
    *
-   * @param errMsgFormat the error message format string.
    * @param t the throwable raised in the called class.
+   * @param errMsgFormat the error message format string.
    * @param args referenced by the format specifiers in the format string.
    * @throws YarnException on failure
    */
   @Public
   @Unstable
-  public static void logAndThrowException(String errMsgFormat, Throwable t, Object... args)
+  public static void logAndThrowException(Throwable t, String errMsgFormat, Object... args)
       throws YarnException {
     String msg = String.format(errMsgFormat, args);
     if (t != null) {
@@ -74,7 +74,7 @@ public static void logAndThrowException(String errMsgFormat, Throwable t, Object
   @Public
   @Unstable
   public static void logAndThrowException(String errMsg, Throwable t)
-          throws YarnException {
+      throws YarnException {
     if (t != null) {
       LOG.error(errMsg, t);
       throw new YarnException(errMsg, t);
@@ -127,14 +127,14 @@ public static void logAndThrowRunTimeException(String errMsg, Throwable t)
   /**
    * Throws an RunTimeException due to an error.
    *
-   * @param errMsgFormat the error message format string.
    * @param t the throwable raised in the called class.
+   * @param errMsgFormat the error message format string.
    * @param args referenced by the format specifiers in the format string.
    * @throws RuntimeException on failure
    */
   @Public
   @Unstable
-  public static void logAndThrowRunTimeException(String errMsgFormat, Throwable t, Object... args)
+  public static void logAndThrowRunTimeException(Throwable t, String errMsgFormat, Object... args)
       throws RuntimeException {
     String msg = String.format(errMsgFormat, args);
     if (t != null) {

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/FederationInterceptorREST.java

@@ -1376,8 +1376,8 @@ public AppAttemptsInfo getAppAttempts(HttpServletRequest hsr, String appId) {
           subClusterInfo.getSubClusterId(), subClusterInfo.getRMWebServiceAddress());
       return interceptor.getAppAttempts(hsr, appId);
     } catch (IllegalArgumentException e) {
-      RouterServerUtil.logAndThrowRunTimeException(
-          "Unable to get the AppAttempt appId: %s.", e, appId);
+      RouterServerUtil.logAndThrowRunTimeException(e,
+          "Unable to get the AppAttempt appId: %s.", appId);
     } catch (YarnException e) {
       RouterServerUtil.logAndThrowRunTimeException("getContainer Failed.", e);
     }
@@ -1409,8 +1409,8 @@ public AppAttemptInfo getAppAttempt(HttpServletRequest req,
           subClusterInfo.getSubClusterId(), subClusterInfo.getRMWebServiceAddress());
       return interceptor.getAppAttempt(req, res, appId, appAttemptId);
     } catch (IllegalArgumentException e) {
-      RouterServerUtil.logAndThrowRunTimeException(
-          "Unable to get the AppAttempt appId: %s, appAttemptId: %s.", e, appId, appAttemptId);
+      RouterServerUtil.logAndThrowRunTimeException(e,
+          "Unable to get the AppAttempt appId: %s, appAttemptId: %s.", appId, appAttemptId);
     } catch (YarnException e) {
       RouterServerUtil.logAndThrowRunTimeException("getContainer Failed.", e);
     }
@@ -1599,14 +1599,14 @@ private SubClusterInfo getHomeSubClusterInfoByAppId(String appId)
       ApplicationId applicationId = ApplicationId.fromString(appId);
       SubClusterId subClusterId = federationFacade.getApplicationHomeSubCluster(applicationId);
       if (subClusterId == null) {
-        RouterServerUtil.logAndThrowException("Can't get HomeSubCluster by applicationId %s",
-            null, applicationId);
+        RouterServerUtil.logAndThrowException(null,
+            "Can't get HomeSubCluster by applicationId %s", applicationId);
       }
       subClusterInfo = federationFacade.getSubCluster(subClusterId);
       return subClusterInfo;
     } catch (YarnException e) {
-      RouterServerUtil.logAndThrowException("Get HomeSubClusterInfo by applicationId %s failed.",
-          e, appId);
+      RouterServerUtil.logAndThrowException(e,
+          "Get HomeSubClusterInfo by applicationId %s failed.", appId);
     }
     throw new YarnException("Unable to get subCluster by applicationId = " + appId);
   }