handle invalid config value gracefully

Author: Bhavay Pahuja

hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java

@@ -584,10 +584,17 @@ public void initialize(URI name, Configuration originalConf)
 
       s3aInternals = createS3AInternals();
 
-      s3ObjectStorageClassFilter = Optional.of(conf.getTrimmed(READ_RESTORED_GLACIER_OBJECTS,
-              DEFAULT_READ_RESTORED_GLACIER_OBJECTS))
-          .map(String::toUpperCase)
-          .map(S3ObjectStorageClassFilter::valueOf).get();
+      try {
+        s3ObjectStorageClassFilter = Optional.of(conf.getTrimmed(READ_RESTORED_GLACIER_OBJECTS,
+                DEFAULT_READ_RESTORED_GLACIER_OBJECTS))
+            .map(String::toUpperCase)
+            .map(S3ObjectStorageClassFilter::valueOf).get();
+      } catch (IllegalArgumentException e) {
+        LOG.warn("Invalid value for the config {} is set. Valid values are:" +
+                "READ_ALL, SKIP_ALL_GLACIER, READ_RESTORED_GLACIER_OBJECTS. Defaulting to READ_ALL",
+            READ_RESTORED_GLACIER_OBJECTS);
+        s3ObjectStorageClassFilter = S3ObjectStorageClassFilter.READ_ALL;
+      }
 
       // look for encryption data
       // DT Bindings may override this

hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/list/ITestS3AReadRestoredGlacierObjects.java

@@ -104,6 +104,17 @@ protected Configuration createConfiguration() {
     return newConf;
   }
 
+  @Test
+  public void testConfigWithInvalidValue() throws Throwable {
+    Assume.assumeTrue(type == Type.GLACIER_AND_DEEP_ARCHIVE);
+    String invalidValue = "ABCDE";
+    try (FileSystem fs = createFiles(invalidValue)) {
+      Assertions.assertThat(
+              fs.listStatus(methodPath()))
+          .describedAs("FileStatus List of %s", methodPath()).isNotEmpty();
+    }
+  }
+
   @Test
   public void testIgnoreGlacierObject() throws Throwable {
     Assume.assumeTrue(type == Type.GLACIER_AND_DEEP_ARCHIVE);