Skip to content

Deprecate adlfs.* configuration properties in favor of adls.* #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Fokko opened this issue Jun 28, 2024 · 2 comments
Closed

Deprecate adlfs.* configuration properties in favor of adls.* #866

Fokko opened this issue Jun 28, 2024 · 2 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@Fokko
Copy link
Contributor

Fokko commented Jun 28, 2024

Feature Request / Improvement

To set up a configuration to ADLS, we use now adlfs.* prefixed properties. This is refers to the implementation, and we want to use adls. See https://py.iceberg.apache.org/configuration/

What we want to do:

  • Replace adlfs to adls, and emit a warning when we see this to let the user know that aldfs is being deprecated.
  • Update the properties and docs with adls.
@Fokko Fokko added the good first issue Good for newcomers label Jun 28, 2024
@ndrluis
Copy link
Collaborator

ndrluis commented Jul 4, 2024

Hello @Fokko,

I'd like to resolve this issue. I just want to confirm the expected behavior. Since we are replacing ADLFS with ADLS, I believe the expected behavior should be to raise an error. If we choose to warn instead, it means we are not replacing ADLFS but supporting both, and we are implying that we will eventually stop supporting the ADLFS prefix.

What should the expected behavior be?

@kevinjqliu
Copy link
Contributor

closed by #961

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants