Skip to content

bug: highest_field_id in schema should include nested fields. #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
liurenjie1024 opened this issue Aug 29, 2024 · 2 comments
Closed

bug: highest_field_id in schema should include nested fields. #589

liurenjie1024 opened this issue Aug 29, 2024 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
0.4.0 Release

Comments

@liurenjie1024
Copy link
Contributor

Currently for a schema like following:

[
  foo (id: 1, type String),
  bar (id: 2, type Struct),
     | - baz (id: 3, type String)
     | - ban (id: 10, type Int)
]

The highest_field_id is calculated as 2 since we don't count nested field. It's supposed to be 10.
@liurenjie1024 liurenjie1024 added bug Something isn't working good first issue Good for newcomers labels Aug 29, 2024
@liurenjie1024 liurenjie1024 added this to the 0.4.0 Release milestone Aug 29, 2024
@liurenjie1024
Copy link
Contributor Author

I'm working on this

@liurenjie1024 liurenjie1024 mentioned this issue Aug 29, 2024
Merged
@Xuanwo
Copy link
Member

Xuanwo commented Sep 10, 2024

Fixed by #590

@Xuanwo Xuanwo closed this as completed Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
iceberg-rust
Status: Done
Milestone
0.4.0 Release
Development

No branches or pull requests
2 participants
@liurenjie1024 @Xuanwo