Skip to content

Commit 996cdcc

Browse files
alexrashedpan3793
authored andcommitted
[KYUUBI #6567] Fix compatibility of pyhive with setuptools==72.0.0
# 🔍 Description ## Issue References 🔗 This pull request fixes #6567 ## Describe Your Solution 🔧 With `setuptools==72.0.0`, the `test` command was removed after being deprecated for a long time. This completely breaks the installation of any packages using the `test` command, including PyHive. This PR fixes PyHive to be compatible with `setuptools` 72+ again. It seems that `setup.py test` wasn't used anywhere at all, which is why I just removed it. ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ ``` $ pip install -e . Obtaining file:///home/localstack/Repos/kyuubi/python Preparing metadata (setup.py) ... error error: subprocess-exited-with-error × python setup.py egg_info did not run successfully. │ exit code: 1 ╰─> [6 lines of output] Traceback (most recent call last): File "<string>", line 2, in <module> File "<pip-setuptools-caller>", line 34, in <module> File "/home/localstack/Repos/kyuubi/python/setup.py", line 4, in <module> from setuptools.command.test import test as TestCommand ModuleNotFoundError: No module named 'setuptools.command.test' [end of output] note: This error originates from a subprocess, and is likely not a problem with pip. error: metadata-generation-failed × Encountered error while generating package metadata. ╰─> See above for output. note: This is an issue with the package mentioned above, not pip. hint: See above for details ``` #### Behavior With This Pull Request 🎉 ``` $ pip install --upgrade setuptools Requirement already satisfied: setuptools in .../.pyenv/versions/3.11.5/lib/python3.11/site-packages (72.0.0) $ pip install -e . Obtaining file:///home/.../repos/kyuubi/python Preparing metadata (setup.py) ... done Collecting future (from PyHive==0.7.0) Obtaining dependency information for future from https://files.pythonhosted.org/packages/da/71/ae30dadffc90b9006d77af76b393cb9dfbfc9629f339fc1574a1c52e6806/future-1.0.0-py3-none-any.whl.metadata Using cached future-1.0.0-py3-none-any.whl.metadata (4.0 kB) Requirement already satisfied: python-dateutil in /home/.../.pyenv/versions/3.11.5/lib/python3.11/site-packages (from PyHive==0.7.0) (2.8.2) Requirement already satisfied: six>=1.5 in /home/.../.pyenv/versions/3.11.5/lib/python3.11/site-packages (from python-dateutil->PyHive==0.7.0) (1.16.0) Using cached future-1.0.0-py3-none-any.whl (491 kB) Installing collected packages: future, PyHive Running setup.py develop for PyHive Successfully installed PyHive-0.7.0 future-1.0.0 [notice] A new release of pip is available: 23.2.1 -> 24.1.2 [notice] To update, run: pip install --upgrade pip ``` #### Related Unit Tests None --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6568 from alexrashed/fix-pyhive-setuptools-72. Closes #6567 acfb809 [Alexander Rashed] remove usage of setuptools.command.test Authored-by: Alexander Rashed <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
1 parent c28d955 commit 996cdcc

File tree

1 file changed

+0
-16
lines changed

1 file changed

+0
-16
lines changed

python/setup.py

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,7 @@
11
#!/usr/bin/env python
22

33
from setuptools import setup
4-
from setuptools.command.test import test as TestCommand
54
import pyhive
6-
import sys
7-
8-
9-
class PyTest(TestCommand):
10-
def finalize_options(self):
11-
TestCommand.finalize_options(self)
12-
self.test_args = []
13-
self.test_suite = True
14-
15-
def run_tests(self):
16-
# import here, cause outside the eggs aren't loaded
17-
import pytest
18-
errno = pytest.main(self.test_args)
19-
sys.exit(errno)
205

216

227
with open('README.rst') as readme:
@@ -62,7 +47,6 @@ def run_tests(self):
6247
'sqlalchemy>=1.3.0',
6348
'thrift>=0.10.0',
6449
],
65-
cmdclass={'test': PyTest},
6650
package_data={
6751
'': ['*.rst'],
6852
},

0 commit comments

Comments
 (0)