Skip to content

Commit 9377649

Browse files
ProjectBuildingRequest should not be modified
We should set new properties on copy of ProjectBuildingRequest not on one returned by MavenSession In other case change can have impact on whole MavenSession
1 parent f99b598 commit 9377649

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

src/main/java/org/apache/maven/plugins/dependency/fromDependencies/AbstractDependencyFilterMojo.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,11 @@
3838
import org.apache.maven.plugins.dependency.utils.ResolverUtil;
3939
import org.apache.maven.plugins.dependency.utils.translators.ArtifactTranslator;
4040
import org.apache.maven.plugins.dependency.utils.translators.ClassifierTypeTranslator;
41+
import org.apache.maven.project.DefaultProjectBuildingRequest;
4142
import org.apache.maven.project.MavenProject;
4243
import org.apache.maven.project.ProjectBuilder;
4344
import org.apache.maven.project.ProjectBuildingException;
45+
import org.apache.maven.project.ProjectBuildingRequest;
4446
import org.apache.maven.shared.artifact.filter.collection.ArtifactFilterException;
4547
import org.apache.maven.shared.artifact.filter.collection.ArtifactIdFilter;
4648
import org.apache.maven.shared.artifact.filter.collection.ArtifactsFilter;
@@ -353,9 +355,10 @@ protected DependencyStatusSets getDependencySets(boolean stopOnFailure, boolean
353355

354356
private MavenProject buildProjectFromArtifact(Artifact artifact) throws MojoExecutionException {
355357
try {
356-
return projectBuilder
357-
.build(artifact, session.getProjectBuildingRequest().setProcessPlugins(false))
358-
.getProject();
358+
ProjectBuildingRequest buildingRequest =
359+
new DefaultProjectBuildingRequest(session.getProjectBuildingRequest());
360+
buildingRequest.setProcessPlugins(false);
361+
return projectBuilder.build(artifact, buildingRequest).getProject();
359362
} catch (ProjectBuildingException e) {
360363
throw new MojoExecutionException("Coud not build project for " + artifact.getId(), e);
361364
}

0 commit comments

Comments
 (0)